Initialize loggingType. Improve paintLogging

Author: PaulZC

Firmware/RTK_Everywhere/Display.ino

@@ -1853,6 +1853,7 @@ void paintLogging(std::vector<iconPropertyBlinking> *iconList, bool pulse, bool
     loggingIconDisplayed %= LOGGING_ICON_STATES; // Wrap
 
     iconPropertyBlinking prop;
+    prop.icon.bitmap = nullptr;
     prop.duty = 0b11111111;
 
     if (((online.logging == true) && (logIncreasing || ntpLogIncreasing)) || (present.gnss_mosaicX5 && logIncreasing))
@@ -1861,6 +1862,10 @@ void paintLogging(std::vector<iconPropertyBlinking> *iconList, bool pulse, bool
         {
             prop.icon = LoggingNTPIconProperties.iconDisplay[loggingIconDisplayed][present.display_type];
         }
+        else if (loggingType == LOGGING_STANDARD)
+        {
+            prop.icon = LoggingIconProperties.iconDisplay[loggingIconDisplayed][present.display_type];
+        }
         else if (loggingType == LOGGING_PPP)
         {
             prop.icon = LoggingPPPIconProperties.iconDisplay[loggingIconDisplayed][present.display_type];
@@ -1869,18 +1874,15 @@ void paintLogging(std::vector<iconPropertyBlinking> *iconList, bool pulse, bool
         {
             prop.icon = LoggingCustomIconProperties.iconDisplay[loggingIconDisplayed][present.display_type];
         }
-        else // if (loggingType == LOGGING_STANDARD)
-        {
-            prop.icon = LoggingIconProperties.iconDisplay[loggingIconDisplayed][present.display_type];
-        }
-
-        iconList->push_back(prop);
+        // Could be LOGGING_UNKNOWN
     }
     else if (pulse)
     {
         prop.icon = PulseIconProperties.iconDisplay[loggingIconDisplayed][present.display_type];
-        iconList->push_back(prop);
     }
+
+    if (prop.icon.bitmap)
+        iconList->push_back(prop);
 }
 
 // Survey in is running. Show 3D Mean and elapsed time.

Firmware/RTK_Everywhere/RTK_Everywhere.ino

@@ -280,7 +280,7 @@ typedef enum LoggingType
     LOGGING_PPP,
     LOGGING_CUSTOM
 } LoggingType;
-LoggingType loggingType;
+LoggingType loggingType = LOGGING_UNKNOWN;
 
 SdFile *managerTempFile = nullptr; // File used for uploading or downloading in the file manager section of AP config
 bool managerFileOpen = false;
@@ -936,7 +936,7 @@ volatile bool deadManWalking;
                                                                                                                        \
         /* Turn on nearly all the debug prints */                                                                      \
         settings.debugCorrections = true;                                                                              \
-        settings.debugGnss = false;                                                                                    \
+        settings.debugGnss = true;                                                                                     \
         settings.debugHttpClientData = true;                                                                           \
         settings.debugHttpClientState = true;                                                                          \
         settings.debugLora = true;                                                                                     \
@@ -981,7 +981,7 @@ volatile bool deadManWalking;
                                                                                                                        \
         /* Turn on nearly all the debug prints */                                                                      \
         settings.debugCorrections = true;                                                                              \
-        settings.debugGnss = false;                                                                                    \
+        settings.debugGnss = true;                                                                                     \
         settings.debugHttpClientData = false;                                                                          \
         settings.debugHttpClientState = true;                                                                          \
         settings.debugLora = false;                                                                                    \