standardize RTC api for setTime and setAlarm

In v1.x.x we are using (hh, mm, ss, hund, dom, mon, year)
Planning to change api in v2.0.0 to (hund, mm, ss, hh, dom, mon, year)

Author: oclyke

libraries/RTC/examples/Example1_Get_Time/Example1_Get_Time.ino

@@ -25,7 +25,7 @@ void setup()
   myRTC.setToCompilerTime();
 
   // Manually set RTC date and time
-  //myRTC.setTime(0, 50, 59, 12, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
+  //myRTC.setTime(12, 59, 50, 0, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
 }
 
 void loop()

libraries/RTC/examples/Example2_Set_Alarms/Example2_Set_Alarms.ino

@@ -28,11 +28,10 @@ void setup()
   //myRTC.setToCompilerTime();
 
   // Manually set RTC date and time
-  myRTC.setTime(0, 50, 59, 12, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
+  myRTC.setTime(12, 59, 50, 0, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
 
   // Set the RTC's alarm
-  myRTC.setAlarm(0, 0, 0, 13, 3, 6); // 13:00:00.000, June 3rd (hund, ss, mm, hh, dd, mm). Note: No year alarm register
-
+  myRTC.setAlarm(13, 0, 0, 0, 3, 6); // 13:00:00.000, June 3rd (hund, ss, mm, hh, dd, mm). Note: No year alarm register
   // Set the RTC alarm mode
   /*
     0: Alarm interrupt disabled

libraries/RTC/examples/Example3_Test_RTC/Example3_Test_RTC.ino

@@ -18,15 +18,15 @@ void setup()
   Serial.println("Artemis RTC Testing");
 
   // Manually set RTC date and time
-  myRTC.setTime(0, 59, 59, 23, 1, 1, 20); // Set to 1 second before midnight
+  myRTC.setTime(23, 59, 59, 0, 1, 1, 20); // Set to 1 second before midnight
 }
 
 void loop()
 {
   printArtemisTime();
 
   myRTC.getTime();
-  myRTC.setTime(99, 59, 59, 23, myRTC.dayOfMonth, myRTC.month, myRTC.year); // Manually set RTC
+  myRTC.setTime(23, 59, 59, 99, myRTC.dayOfMonth, myRTC.month, myRTC.year); // Manually set RTC
   delay(11); //Allow us to roll from midnight the night before to the new day
 }
 

libraries/RTC/examples/Example5_Rolling_Alarms/Example5_Rolling_Alarms.ino

@@ -28,10 +28,10 @@ void setup()
   //myRTC.setToCompilerTime();
 
   // Manually set RTC date and time
-  myRTC.setTime(0, 50, 59, 12, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
+  myRTC.setTime(12, 59, 50, 0, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
 
   // Set the RTC's alarm
-  myRTC.setAlarm(0, 0, 0, 13, 3, 6); // 13:00:00.000, June 3rd (hund, ss, mm, hh, dd, mm). Note: No year alarm register
+  myRTC.setAlarm(13, 0, 0, 0, 3, 6); // 13:00:00.000, June 3rd (hund, ss, mm, hh, dd, mm). Note: No year alarm register
 
   // Set the RTC alarm mode
   /*
@@ -63,9 +63,10 @@ void loop()
     alarmFlag = false;
 
     // Set the RTC's rolling alarm
-    myRTC.setAlarm(0, (myRTC.seconds + alarmSeconds) % 60,
+    myRTC.setAlarm((myRTC.hour + alarmHours) % 24,
                    (myRTC.minute + alarmMinutes) % 60,
-                   (myRTC.hour + alarmHours) % 24,
+                   (myRTC.seconds + alarmSeconds) % 60,
+                   0,
                    myRTC.dayOfMonth,
                    myRTC.month);
     myRTC.setAlarmMode(6);

libraries/RTC/examples/Example6_LowPower_Alarm/Example6_LowPower_Alarm.ino

@@ -24,10 +24,10 @@ void setup()
   //myRTC.setToCompilerTime();
 
   // Manually set RTC date and time
-  myRTC.setTime(0, 50, 59, 12, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
+  myRTC.setTime(12, 59, 50, 0, 3, 6, 20); // 12:59:50.000, June 3rd, 2020 (hund, ss, mm, hh, dd, mm, yy)
 
   // Set the RTC's alarm
-  myRTC.setAlarm(0, 0, 0, 13, 3, 6); // 13:00:00.000, June 3rd (hund, ss, mm, hh, dd, mm). Note: No year alarm register
+  myRTC.setAlarm(13, 0, 0, 0, 3, 6); // 13:00:00.000, June 3rd (hund, ss, mm, hh, dd, mm). Note: No year alarm register
 
   // Set the RTC alarm mode
   /*

libraries/RTC/src/RTC.cpp

@@ -54,7 +54,7 @@ APM3_RTC::APM3_RTC()
 
 // Note: Order of parameters to change in v2.0.0.
 void APM3_RTC::setTime(uint8_t hour, uint8_t min, uint8_t sec, uint8_t hund, uint8_t dayOfMonth, uint8_t month, uint16_t year)
-
+{
   hal_time.ui32Weekday = am_util_time_computeDayofWeek(2000 + year, month, dayOfMonth); //computeDayofWeek is expecting 1 to 12 months
   hal_time.ui32Century = 0;
   hal_time.ui32Year = year;
@@ -157,7 +157,8 @@ void APM3_RTC::getAlarm()
   alarmHundredths = alm_time.ui32Hundredths;
 }
 
-void APM3_RTC::setAlarm(uint8_t hund, uint8_t sec, uint8_t min, uint8_t hour, uint8_t dayOfMonth, uint8_t month)
+// Note: Order of parameters to change in v2.0.0.
+void APM3_RTC::setAlarm(uint8_t hour, uint8_t min, uint8_t sec, uint8_t hund, uint8_t dayOfMonth, uint8_t month)
 {
   alm_time.ui32Weekday = 0; // WIP
   alm_time.ui32Month = month;

libraries/RTC/src/RTC.h

@@ -17,7 +17,7 @@ class APM3_RTC
   void setEpoch(uint32_t ts); //Set current time to provided UNIX Epoch time
 
   void getAlarm(); //Query the RTC for the current alarm time/date
-  void setAlarm(uint8_t hund, uint8_t sec, uint8_t min, uint8_t hour, uint8_t dayOfMonth, uint8_t month); //Set alarm time to provided hundredths/seconds/etc
+  void setAlarm(uint8_t hour, uint8_t min, uint8_t sec, uint8_t hund, uint8_t dayOfMonth, uint8_t month); //Set alarm time to provided hundredths/seconds/etc
   void setAlarmMode(uint8_t mode); //Set the RTC alarm repeat interval
   void attachInterrupt(); //Attach the RTC alarm interrupt
   void detachInterrupt(); //Detach the RTC alarm interrupt