From fc9deaa65b3f5a432195b6652c85c80b0f53b08d Mon Sep 17 00:00:00 2001 From: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com> Date: Wed, 5 Mar 2025 20:14:04 +0000 Subject: [PATCH 1/3] Fix 515.1621 --- crates/byondapi-rs/src/value/functions.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crates/byondapi-rs/src/value/functions.rs b/crates/byondapi-rs/src/value/functions.rs index a70c4e9..30a850f 100644 --- a/crates/byondapi-rs/src/value/functions.rs +++ b/crates/byondapi-rs/src/value/functions.rs @@ -117,6 +117,7 @@ impl ByondValue { /// Replaces whatever is currently in this value with a string that's pointed to by the stringid /// # DO NOT PASS STRINGIDS THAT ARE NOT RETURNED BY [`crate::byond_string::str_id_of`] + #[cfg(feature = "byond-516-1651")] pub fn set_strid(&mut self, strid: u4c) { unsafe { byond().ByondValue_SetStrId(&mut self.0, strid) } } @@ -249,6 +250,7 @@ impl ByondValue { unsafe { byond().ByondValue_DecRef(&self.0) } } + #[cfg(feature = "byond-516-1651")] pub fn decrement_tempref(&mut self) { unsafe { byond().ByondValue_DecTempRef(&self.0) } } From 1086a0eea92113e4709263c1dbf371b78c813a40 Mon Sep 17 00:00:00 2001 From: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com> Date: Wed, 5 Mar 2025 20:32:25 +0000 Subject: [PATCH 2/3] Lets try matrix this --- .github/workflows/check.yml | 3 ++- crates/byondapi-rs-test/Cargo.toml | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 48e1d8d..4a87214 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -12,6 +12,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: + feature_flags: [byond-515-1621, byond-516-1651] include: - os: ubuntu-latest target_name: i686-unknown-linux-gnu @@ -39,7 +40,7 @@ jobs: with: toolchain: stable command: check - args: --target ${{ matrix.target_name }} + args: --target ${{ matrix.target_name }} --no-default-features --features ${{ matrix.feature_flags }} check_fmt: name: Check format diff --git a/crates/byondapi-rs-test/Cargo.toml b/crates/byondapi-rs-test/Cargo.toml index edfe2cb..4928ddc 100644 --- a/crates/byondapi-rs-test/Cargo.toml +++ b/crates/byondapi-rs-test/Cargo.toml @@ -9,7 +9,12 @@ edition = "2021" crate-type = ["cdylib"] [dependencies] -byondapi = { path = "../byondapi-rs" } +byondapi = { path = "../byondapi-rs", default-features = false } tempfile = "3.17.1" cargo_metadata = "0.19.1" eyre = "0.6.12" + +[features] +default = ["byond-516-1651"] +byond-515-1621 = ["byondapi/byond-515-1621",] +byond-516-1651 = ["byondapi/byond-516-1651"] \ No newline at end of file From a18e550c5df65b50c04e8934e20f67dfa7f46e33 Mon Sep 17 00:00:00 2001 From: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com> Date: Wed, 5 Mar 2025 20:37:05 +0000 Subject: [PATCH 3/3] Oh god I bought actions debugging to byondapi --- .github/workflows/check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 4a87214..cf9f821 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -13,6 +13,7 @@ jobs: strategy: matrix: feature_flags: [byond-515-1621, byond-516-1651] + os: [ubuntu-latest, windows-latest] include: - os: ubuntu-latest target_name: i686-unknown-linux-gnu