Skip to content

Support pre-1.0 versions #139

@jtniehof

Description

@jtniehof

The Version class (at a minimum, probably elsewhere) requires the major version number to be at least 1. That makes it hard to set up test dbprocessing chains using pre-1.0 codes.

Relation to an issue

None

Proposed enhancement

It should be fairly straightforward to just remove the checks and allow major version to be zero.

Alternatives

Keep the current state. It's not clear it was a carefully considered design decision; there's just a note that goes back to 6e97bfa and the actual check goes back to the first commit of 2220578

@balarsen do you remember this?

OS, Python version, and dependency version information:

Linux-6.5.0-28-generic-x86_64-with-glibc2.38
sys.version_info(major=3, minor=11, micro=6, releaselevel='final', serial=0)
sqlalchemy=1.4.47

Version of dbprocessing

Current main.

Closure condition

This issue should be closed when either this is abandoned, or we have checked-in passing tests that use major versions of zero in code and files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or feature request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions