Commit 14c5358
committed
Formalize PR code review policy w/ pullapprove.com
- Right now:
- At least one person form SI (@zbeekman, @rouson, @afanfa) must approve a PR
- Approver may be the PR Author
- This is the regexp to match approval via comments:
`'^([Aa]pproved|:\+1:|:shipit:|:ship: it|LGTM|:zap:|:boom:|:clap:|:bow:)'`
- This is the regexp to reject via comment:
`'^([Nn]ope|[Nn]ope\.jpg|[Dd]enied|[Rr]ejected|:\-1:)'`
- Approve or reject at pullapprove.com as well1 parent 327523d commit 14c5358
2 files changed
+12
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments