Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit e4ee9b9

Browse files
authored
add otherCompletionProviders to privateMetadata allowlist (#64508)
PR adds `otherCompletionProviders` as an allowlisted key for `privateMetadata`. <!-- PR description tips: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e --> ## Test plan Updated test to validate multiple allowlisted keys for one feature <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
1 parent 8ad337e commit e4ee9b9

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

internal/telemetry/sensitivemetadataallowlist/sensitivemetadataallowlist.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,14 @@ func AllowedEventTypes() EventTypes {
4040
// The 'languageId' key is included for feature:'cody.completions' events to provide
4141
// customers with valuable language-specific insights from the analytics we offer.
4242
// This information helps them better understand code completion usage patterns.
43+
// The 'otherCompletionProviders' key is included to provide internal teams insights on
44+
// competitor completion providers customers are using.
4345
EventType{
4446
Feature: "cody.completion",
4547
Action: "*",
4648
AllowedPrivateMetadataKeys: []string{
4749
"languageId",
50+
"otherCompletionProviders",
4851
},
4952
},
5053
// The 'languageId' key is included for feature:'cody.hoverCommands' action: 'visible' events to provide

internal/telemetry/sensitivemetadataallowlist/sensitivemetadataallowlist_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ func TestIsAllowed(t *testing.T) {
5050
expectAllowed: true,
5151
expectAllowlist: []string{
5252
"languageId",
53+
"otherCompletionProviders",
5354
},
5455
},
5556
{

0 commit comments

Comments
 (0)