Remove externalServiceUserMode configuration (#57445)

Those services are no longer supported, just removing some more leftovers of that.

Author: eseliger

client/branded/src/search-ui/input/SearchBox.tsx

@@ -46,9 +46,6 @@ export interface SearchBoxProps
     /** Don't show search help button */
     hideHelpButton?: boolean
 
-    /** Set in JSContext only available to the web app. */
-    isExternalServicesUserModeAll?: boolean
-
     /** Called with the underlying editor instance on creation. */
     onEditorCreated?: (editor: IEditor) => void
 

client/jetbrains/webview/src/search/input/JetBrainsSearchBox.tsx

@@ -46,9 +46,6 @@ export interface JetBrainsSearchBoxProps
     /** Don't show search help button */
     hideHelpButton?: boolean
 
-    /** Set in JSContext only available to the web app. */
-    isExternalServicesUserModeAll?: boolean
-
     /** Called with the underlying editor instance on creation. */
     onEditorCreated?: (editor: IEditor) => void
 }

client/web/dev/utils/create-js-context.ts

@@ -37,7 +37,6 @@ export const createJsContext = ({ sourcegraphBaseUrl }: { sourcegraphBaseUrl: st
         codeIntelAutoIndexingEnabled: false,
         codeIntelAutoIndexingAllowGlobalPolicies: false,
         codeInsightsEnabled: true,
-        externalServicesUserMode: 'public',
         productResearchPageEnabled: true,
         assetsRoot: '/.assets',
         deployType: 'dev',

client/web/src/integration/jscontext.ts

@@ -32,7 +32,6 @@ export const createJsContext = ({ sourcegraphBaseUrl }: { sourcegraphBaseUrl: st
     extsvcConfigFileExists: false,
     codeIntelAutoIndexingEnabled: true,
     codeIntelAutoIndexingAllowGlobalPolicies: true,
-    externalServicesUserMode: 'disabled',
     productResearchPageEnabled: true,
     assetsRoot: new URL('/.assets', sourcegraphBaseUrl).href,
     deployType: 'dev',

client/web/src/jscontext.ts

@@ -206,9 +206,6 @@ export interface SourcegraphContext extends Pick<Required<SiteConfiguration>, 'e
      */
     srcServeGitUrl: string
 
-    /** Whether users are allowed to add their own code and at what permission level. */
-    externalServicesUserMode: 'disabled' | 'public' | 'all' | 'unknown'
-
     /** Authentication provider instances in site config. */
     authProviders: AuthProvider[]
 

client/web/src/search/input/SearchNavbarItem.tsx

@@ -139,7 +139,6 @@ export const SearchNavbarItem: React.FunctionComponent<React.PropsWithChildren<P
                 onSubmit={onSubmit}
                 submitSearchOnToggle={submitSearchOnChange}
                 submitSearchOnSearchContextChange={submitSearchOnChange}
-                isExternalServicesUserModeAll={window.context.externalServicesUserMode === 'all'}
                 structuralSearchDisabled={window.context?.experimentalFeatures?.structuralSearch === 'disabled'}
                 hideHelpButton={false}
                 showSearchHistory={true}

client/web/src/storm/pages/SearchPage/SearchPageInput.tsx

@@ -183,7 +183,6 @@ export const SearchPageInput: FC<SearchPageInputProps> = props => {
             onChange={setQueryState}
             onSubmit={onSubmit}
             autoFocus={!isTouchOnlyDevice}
-            isExternalServicesUserModeAll={window.context.externalServicesUserMode === 'all'}
             structuralSearchDisabled={window.context?.experimentalFeatures?.structuralSearch === 'disabled'}
             showSearchHistory={true}
             recentSearches={recentSearches}

cmd/frontend/internal/app/jscontext/jscontext.go

@@ -161,8 +161,6 @@ type JSContext struct {
 
 	ResetPasswordEnabled bool `json:"resetPasswordEnabled"`
 
-	ExternalServicesUserMode string `json:"externalServicesUserMode"`
-
 	AuthMinPasswordLength int                `json:"authMinPasswordLength"`
 	AuthPasswordPolicy    authPasswordPolicy `json:"authPasswordPolicy"`
 
@@ -357,8 +355,6 @@ func NewJSContextFromRequest(req *http.Request, db database.DB) JSContext {
 
 		ResetPasswordEnabled: userpasswd.ResetPasswordEnabled(),
 
-		ExternalServicesUserMode: conf.ExternalServiceUserMode().String(),
-
 		AllowSignup: conf.AuthAllowSignup(),
 
 		AuthMinPasswordLength: conf.AuthMinPasswordLength(),

internal/conf/computed.go

@@ -497,41 +497,6 @@ func AuthLockout() *schema.AuthLockout {
 	return val
 }
 
-type ExternalServiceMode int
-
-const (
-	ExternalServiceModeDisabled ExternalServiceMode = 0
-	ExternalServiceModePublic   ExternalServiceMode = 1
-	ExternalServiceModeAll      ExternalServiceMode = 2
-)
-
-func (e ExternalServiceMode) String() string {
-	switch e {
-	case ExternalServiceModeDisabled:
-		return "disabled"
-	case ExternalServiceModePublic:
-		return "public"
-	case ExternalServiceModeAll:
-		return "all"
-	default:
-		return "unknown"
-	}
-}
-
-// ExternalServiceUserMode returns the site level mode describing if users are
-// allowed to add external services for public and private repositories. It does
-// NOT take into account permissions granted to the current user.
-func ExternalServiceUserMode() ExternalServiceMode {
-	switch Get().ExternalServiceUserMode {
-	case "public":
-		return ExternalServiceModePublic
-	case "all":
-		return ExternalServiceModeAll
-	default:
-		return ExternalServiceModeDisabled
-	}
-}
-
 const defaultGitLongCommandTimeout = time.Hour
 
 // GitLongCommandTimeout returns the maximum amount of time in seconds that a