update build and fix lodash issue in esbuild on firefox

Author: sqs

client/browser/config/esbuild.ts

@@ -33,14 +33,15 @@ export function esbuildBuildOptions(mode: 'dev' | 'prod', extraPlugins: esbuild.
             // Worker
             path.resolve(browserSourcePath, 'shared/extensionHostWorker.ts'),
         ],
-        format: 'cjs',
+        format: 'esm',
         platform: 'browser',
         plugins: [stylePlugin, ...extraPlugins],
         define: {
             'process.env.NODE_ENV': JSON.stringify(mode === 'dev' ? 'development' : 'production'),
             'process.env.BUNDLE_UID': JSON.stringify(generateBundleUID()),
         },
         bundle: true,
+        treeShaking: true,
         minify: false,
         logLevel: 'error',
         jsx: 'automatic',
@@ -49,7 +50,12 @@ export function esbuildBuildOptions(mode: 'dev' | 'prod', extraPlugins: esbuild.
         entryNames: '[ext]/[name].bundle',
         target: 'esnext',
         sourcemap: true,
-        alias: { path: 'path-browserify' },
+        alias: { path: 'path-browserify', lodash: 'lodash-es' },
+        banner: {
+            // HACK: lodash has a `Function("return this")`, which Firefox's CSP protection
+            // complains about. This ensures we do not encounter it.
+            js: 'globalThis.global = globalThis;',
+        },
         loader: {
             '.svg': 'text',
         },

client/build-config/package.json

@@ -16,7 +16,6 @@
   "dependencies": {
     "buffer": "^6.0.3",
     "enhanced-resolve": "^5.9.3",
-    "esbuild": "^0.17.7",
     "monaco-editor-webpack-plugin": "^3.1.0",
     "postcss": "^8.4.19",
     "postcss-cli": "^10.1.0",

package.json

@@ -194,7 +194,7 @@
     "dedent": "^0.7.0",
     "dompurify": "^3.0.6",
     "envalid": "^7.3.1",
-    "esbuild": "^0.17.14",
+    "esbuild": "^0.23.0",
     "eslint": "^8.52.0",
     "eslint-plugin-monorepo": "^0.3.2",
     "eslint-plugin-react": "^7.33.2",