refactor: use String.AsSpan(int, int) instead of String.AsSpan().Slice(int, int)

love-linger · love-linger · commit 825b74c2a3fb · 2025-04-29T09:44:06.000+08:00
Signed-off-by: leo &lt;longshuang@msn.cn&gt;
diff --git a/src/Commands/Diff.cs b/src/Commands/Diff.cs
@@ -105,7 +105,7 @@ private void ParseLine(string line)
                     }
                     else if (line.StartsWith("-size ", StringComparison.Ordinal))
                     {
-                        _result.LFSDiff.Old.Size = long.Parse(line.AsSpan().Slice(6));
+                        _result.LFSDiff.Old.Size = long.Parse(line.AsSpan(6));
                     }
                 }
                 else if (ch == '+')
@@ -116,12 +116,12 @@ private void ParseLine(string line)
                     }
                     else if (line.StartsWith("+size ", StringComparison.Ordinal))
                     {
-                        _result.LFSDiff.New.Size = long.Parse(line.AsSpan().Slice(6));
+                        _result.LFSDiff.New.Size = long.Parse(line.AsSpan(6));
                     }
                 }
                 else if (line.StartsWith(" size ", StringComparison.Ordinal))
                 {
-                    _result.LFSDiff.New.Size = _result.LFSDiff.Old.Size = long.Parse(line.AsSpan().Slice(6));
+                    _result.LFSDiff.New.Size = _result.LFSDiff.Old.Size = long.Parse(line.AsSpan(6));
                 }
                 return;
             }
diff --git a/src/Commands/Statistics.cs b/src/Commands/Statistics.cs
@@ -40,7 +40,7 @@ private void ParseLine(Models.Statistics statistics, string line)
             if (dateEndIdx == -1)
                 return;
 
-            var dateStr = line.AsSpan().Slice(0, dateEndIdx);
+            var dateStr = line.AsSpan(0, dateEndIdx);
             if (double.TryParse(dateStr, out var date))
                 statistics.AddCommit(line.Substring(dateEndIdx + 1), date);
         }
diff --git a/src/Converters/PathConverters.cs b/src/Converters/PathConverters.cs
@@ -22,7 +22,7 @@ public static class PathConverters
                 var home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
                 var prefixLen = home.EndsWith('/') ? home.Length - 1 : home.Length;
                 if (v.StartsWith(home, StringComparison.Ordinal))
-                    return $"~{v.AsSpan().Slice(prefixLen)}";
+                    return $"~{v.AsSpan(prefixLen)}";
 
                 return v;
             });
diff --git a/src/Models/AvatarManager.cs b/src/Models/AvatarManager.cs
@@ -196,7 +196,7 @@ private void LoadDefaultAvatar(string key, string img)
         private string GetEmailHash(string email)
         {
             var lowered = email.ToLower(CultureInfo.CurrentCulture).Trim();
-            var hash = MD5.HashData(Encoding.Default.GetBytes(lowered).AsSpan());
+            var hash = MD5.HashData(Encoding.Default.GetBytes(lowered));
             var builder = new StringBuilder(hash.Length * 2);
             foreach (var c in hash)
                 builder.Append(c.ToString("x2"));
diff --git a/src/Models/DiffResult.cs b/src/Models/DiffResult.cs
@@ -148,9 +148,9 @@ public TextDiffSelection MakeSelection(int startLine, int endLine, bool isCombin
         public void GenerateNewPatchFromSelection(Change change, string fileBlobGuid, TextDiffSelection selection, bool revert, string output)
         {
             var isTracked = !string.IsNullOrEmpty(fileBlobGuid);
-            var fileGuid = isTracked ? fileBlobGuid.AsSpan().Slice(0, 8) : "00000000".AsSpan();
+            var fileGuid = isTracked ? fileBlobGuid : "00000000";
 
-            var builder = new StringBuilder(512);
+            var builder = new StringBuilder();
             builder.Append("diff --git a/").Append(change.Path).Append(" b/").Append(change.Path).Append('\n');
             if (!revert && !isTracked)
                 builder.Append("new file mode 100644\n");
diff --git a/src/Models/Worktree.cs b/src/Models/Worktree.cs
@@ -23,7 +23,7 @@ public string Name
             get
             {
                 if (IsDetached)
-                    return $"deteched HEAD at {Head.AsSpan().Slice(10)}";
+                    return $"deteched HEAD at {Head.AsSpan(10)}";
 
                 if (Branch.StartsWith("refs/heads/", StringComparison.Ordinal))
                     return Branch.Substring(11);
diff --git a/src/ViewModels/Archive.cs b/src/ViewModels/Archive.cs
@@ -32,7 +32,7 @@ public Archive(Repository repo, Models.Commit commit)
         {
             _repo = repo;
             _revision = commit.SHA;
-            _saveFile = $"archive-{commit.SHA.AsSpan().Slice(0, 10)}.zip";
+            _saveFile = $"archive-{commit.SHA.AsSpan(0, 10)}.zip";
             BasedOn = commit;
         }
 
diff --git a/src/ViewModels/Blame.cs b/src/ViewModels/Blame.cs
@@ -31,7 +31,7 @@ public Blame(string repo, string file, string revision)
         {
             _repo = repo;
 
-            Title = $"{file} @ {revision.AsSpan().Slice(0, 10)}";
+            Title = $"{file} @ {revision.AsSpan(0, 10)}";
             Task.Run(() =>
             {
                 var result = new Commands.Blame(repo, file, revision).Result();
diff --git a/src/ViewModels/Launcher.cs b/src/ViewModels/Launcher.cs
@@ -584,7 +584,7 @@ private void UpdateTitle()
                     var home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
                     var prefixLen = home.EndsWith('/') ? home.Length - 1 : home.Length;
                     if (path.StartsWith(home, StringComparison.Ordinal))
-                        path = $"~{path.AsSpan().Slice(prefixLen)}";
+                        path = $"~{path.AsSpan(prefixLen)}";
                 }
 
                 Title = $"[{workspace}] {name} ({path})";
diff --git a/src/ViewModels/WorkingCopy.cs b/src/ViewModels/WorkingCopy.cs
@@ -635,7 +635,7 @@ public ContextMenu CreateContextMenuForUnstagedChanges()
                     }
                     else if (_inProgressContext is RevertInProgress revert)
                     {
-                        useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan().Slice(0, 10)} (revert)");
+                        useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan(0, 10)} (revert)");
                         useMine.Header = App.Text("FileCM.ResolveUsing", _repo.CurrentBranch.Name);
                     }
                     else if (_inProgressContext is MergeInProgress merge)
@@ -993,7 +993,7 @@ public ContextMenu CreateContextMenuForUnstagedChanges()
                     }
                     else if (_inProgressContext is RevertInProgress revert)
                     {
-                        useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan().Slice(0, 10)} (revert)");
+                        useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan(0, 10)} (revert)");
                         useMine.Header = App.Text("FileCM.ResolveUsing", _repo.CurrentBranch.Name);
                     }
                     else if (_inProgressContext is MergeInProgress merge)
@@ -1417,7 +1417,7 @@ public ContextMenu CreateContextMenuForCommitMessages()
                         var home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
                         var prefixLen = home.EndsWith('/') ? home.Length - 1 : home.Length;
                         if (gitTemplate.StartsWith(home, StringComparison.Ordinal))
-                            friendlyName = $"~{gitTemplate.AsSpan().Slice(prefixLen)}";
+                            friendlyName = $"~{gitTemplate.AsSpan(prefixLen)}";
                     }
 
                     var gitTemplateItem = new MenuItem();
diff --git a/src/Views/Histories.axaml.cs b/src/Views/Histories.axaml.cs
@@ -205,7 +205,7 @@ private void OnCommitListKeyDown(object sender, KeyEventArgs e)
                     foreach (var item in selected)
                     {
                         if (item is Models.Commit commit)
-                            builder.AppendLine($"{commit.SHA.AsSpan().Slice(0, 10)} - {commit.Subject}");
+                            builder.AppendLine($"{commit.SHA.AsSpan(0, 10)} - {commit.Subject}");
                     }
 
                     App.CopyText(builder.ToString());
diff --git a/src/Views/TextDiffView.axaml.cs b/src/Views/TextDiffView.axaml.cs
@@ -1047,7 +1047,7 @@ private void CopyWithoutIndicators()
                 // The first selected line (partial selection)
                 if (i == startIdx && startPosition.Column > 1)
                 {
-                    builder.Append(line.Content.AsSpan().Slice(startPosition.Column - 1));
+                    builder.Append(line.Content.AsSpan(startPosition.Column - 1));
                     builder.Append(Environment.NewLine);
                     continue;
                 }
@@ -1064,7 +1064,7 @@ private void CopyWithoutIndicators()
                 {
                     if (endPosition.Column - 1 < line.Content.Length)
                     {
-                        builder.Append(line.Content.AsSpan().Slice(0, endPosition.Column - 1));
+                        builder.Append(line.Content.AsSpan(0, endPosition.Column - 1));
                     }
                     else
                     {
@@ -1254,12 +1254,12 @@ protected override void OnDataContextChanged(EventArgs e)
             var textDiff = DataContext as Models.TextDiff;
             if (textDiff != null)
             {
-                var builder = new StringBuilder(512);
+                var builder = new StringBuilder();
                 foreach (var line in textDiff.Lines)
                 {
                     if (line.Content.Length > 10000)
                     {
-                        builder.Append(line.Content.AsSpan().Slice(0, 1000));
+                        builder.Append(line.Content.AsSpan(0, 1000));
                         builder.Append($"...({line.Content.Length - 1000} character trimmed)");
                     }
                     else

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ private void ParseLine(string line)`
`105`	`105`	`}`
`106`	`106`	`else if (line.StartsWith("-size ", StringComparison.Ordinal))`
`107`	`107`	`{`
`108`		`- _result.LFSDiff.Old.Size = long.Parse(line.AsSpan().Slice(6));`
	`108`	`+ _result.LFSDiff.Old.Size = long.Parse(line.AsSpan(6));`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`	`else if (ch == '+')`
`@@ -116,12 +116,12 @@ private void ParseLine(string line)`
`116`	`116`	`}`
`117`	`117`	`else if (line.StartsWith("+size ", StringComparison.Ordinal))`
`118`	`118`	`{`
`119`		`- _result.LFSDiff.New.Size = long.Parse(line.AsSpan().Slice(6));`
	`119`	`+ _result.LFSDiff.New.Size = long.Parse(line.AsSpan(6));`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`	`else if (line.StartsWith(" size ", StringComparison.Ordinal))`
`123`	`123`	`{`
`124`		`- _result.LFSDiff.New.Size = _result.LFSDiff.Old.Size = long.Parse(line.AsSpan().Slice(6));`
	`124`	`+ _result.LFSDiff.New.Size = _result.LFSDiff.Old.Size = long.Parse(line.AsSpan(6));`
`125`	`125`	`}`
`126`	`126`	`return;`
`127`	`127`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ private void ParseLine(Models.Statistics statistics, string line)`
`40`	`40`	`if (dateEndIdx == -1)`
`41`	`41`	`return;`
`42`	`42`
`43`		`- var dateStr = line.AsSpan().Slice(0, dateEndIdx);`
	`43`	`+ var dateStr = line.AsSpan(0, dateEndIdx);`
`44`	`44`	`if (double.TryParse(dateStr, out var date))`
`45`	`45`	`statistics.AddCommit(line.Substring(dateEndIdx + 1), date);`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ private void LoadDefaultAvatar(string key, string img)`
`196`	`196`	`private string GetEmailHash(string email)`
`197`	`197`	`{`
`198`	`198`	`var lowered = email.ToLower(CultureInfo.CurrentCulture).Trim();`
`199`		`- var hash = MD5.HashData(Encoding.Default.GetBytes(lowered).AsSpan());`
	`199`	`+ var hash = MD5.HashData(Encoding.Default.GetBytes(lowered));`
`200`	`200`	`var builder = new StringBuilder(hash.Length * 2);`
`201`	`201`	`foreach (var c in hash)`
`202`	`202`	`builder.Append(c.ToString("x2"));`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public string Name`
`23`	`23`	`get`
`24`	`24`	`{`
`25`	`25`	`if (IsDetached)`
`26`		`- return $"deteched HEAD at {Head.AsSpan().Slice(10)}";`
	`26`	`+ return $"deteched HEAD at {Head.AsSpan(10)}";`
`27`	`27`
`28`	`28`	`if (Branch.StartsWith("refs/heads/", StringComparison.Ordinal))`
`29`	`29`	`return Branch.Substring(11);`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public Archive(Repository repo, Models.Commit commit)`
`32`	`32`	`{`
`33`	`33`	`_repo = repo;`
`34`	`34`	`_revision = commit.SHA;`
`35`		`- _saveFile = $"archive-{commit.SHA.AsSpan().Slice(0, 10)}.zip";`
	`35`	`+ _saveFile = $"archive-{commit.SHA.AsSpan(0, 10)}.zip";`
`36`	`36`	`BasedOn = commit;`
`37`	`37`	`}`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public Blame(string repo, string file, string revision)`
`31`	`31`	`{`
`32`	`32`	`_repo = repo;`
`33`	`33`
`34`		`- Title = $"{file} @ {revision.AsSpan().Slice(0, 10)}";`
	`34`	`+ Title = $"{file} @ {revision.AsSpan(0, 10)}";`
`35`	`35`	`Task.Run(() =>`
`36`	`36`	`{`
`37`	`37`	`var result = new Commands.Blame(repo, file, revision).Result();`
Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ private void UpdateTitle()`
`584`	`584`	`var home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);`
`585`	`585`	`var prefixLen = home.EndsWith('/') ? home.Length - 1 : home.Length;`
`586`	`586`	`if (path.StartsWith(home, StringComparison.Ordinal))`
`587`		`- path = $"~{path.AsSpan().Slice(prefixLen)}";`
	`587`	`+ path = $"~{path.AsSpan(prefixLen)}";`
`588`	`588`	`}`
`589`	`589`
`590`	`590`	`Title = $"[{workspace}] {name} ({path})";`
Original file line number	Diff line number	Diff line change
`@@ -635,7 +635,7 @@ public ContextMenu CreateContextMenuForUnstagedChanges()`
`635`	`635`	`}`
`636`	`636`	`else if (_inProgressContext is RevertInProgress revert)`
`637`	`637`	`{`
`638`		`- useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan().Slice(0, 10)} (revert)");`
	`638`	`+ useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan(0, 10)} (revert)");`
`639`	`639`	`useMine.Header = App.Text("FileCM.ResolveUsing", _repo.CurrentBranch.Name);`
`640`	`640`	`}`
`641`	`641`	`else if (_inProgressContext is MergeInProgress merge)`
`@@ -993,7 +993,7 @@ public ContextMenu CreateContextMenuForUnstagedChanges()`
`993`	`993`	`}`
`994`	`994`	`else if (_inProgressContext is RevertInProgress revert)`
`995`	`995`	`{`
`996`		`- useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan().Slice(0, 10)} (revert)");`
	`996`	`+ useTheirs.Header = App.Text("FileCM.ResolveUsing", $"{revert.Head.SHA.AsSpan(0, 10)} (revert)");`
`997`	`997`	`useMine.Header = App.Text("FileCM.ResolveUsing", _repo.CurrentBranch.Name);`
`998`	`998`	`}`
`999`	`999`	`else if (_inProgressContext is MergeInProgress merge)`
`@@ -1417,7 +1417,7 @@ public ContextMenu CreateContextMenuForCommitMessages()`
`1417`	`1417`	`var home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);`
`1418`	`1418`	`var prefixLen = home.EndsWith('/') ? home.Length - 1 : home.Length;`
`1419`	`1419`	`if (gitTemplate.StartsWith(home, StringComparison.Ordinal))`
`1420`		`- friendlyName = $"~{gitTemplate.AsSpan().Slice(prefixLen)}";`
	`1420`	`+ friendlyName = $"~{gitTemplate.AsSpan(prefixLen)}";`
`1421`	`1421`	`}`
`1422`	`1422`
`1423`	`1423`	`var gitTemplateItem = new MenuItem();`