Add document discrinator sanitizer for JSON protocols #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Nov 14, 2025
...nt-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJsonProtocol.java
Show resolved
Hide resolved
...t-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJson1Protocol.java
Outdated
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/JsonSettings.java
Outdated
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/ErrorTypeSanitizer.java
Outdated
Show resolved
Hide resolved
sugmanue
reviewed
Nov 14, 2025
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/ErrorTypeSanitizer.java
Outdated
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/ErrorTypeSanitizer.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Dec 3, 2025
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/JsonDocuments.java
Outdated
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/JsonDocuments.java
Outdated
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/JsonSettings.java
Outdated
Show resolved
Hide resolved
joewyz
force-pushed
the
joewyz/restjson11-protocol-test-fix
branch
from
f3e8989 to
9e15a74
Compare
mtdowling
requested changes
Dec 8, 2025
...ent-rpcv2-cbor/src/main/java/software/amazon/smithy/java/client/rpcv2/RpcV2CborProtocol.java
Outdated
Show resolved
Hide resolved
...-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJson11Protocol.java
Outdated
Show resolved
Hide resolved
...client-http/src/main/java/software/amazon/smithy/java/client/http/HttpErrorDeserializer.java
Show resolved
Hide resolved
codecs/json-codec/src/main/java/software/amazon/smithy/java/json/JsonSettings.java
Outdated
Show resolved
Hide resolved
client/client-http/src/main/java/software/amazon/smithy/java/client/http/ErrorTypeUtils.java
Outdated
Show resolved
Hide resolved
...nt/client-http/src/test/java/software/amazon/smithy/java/client/http/ErrorTypeUtilsTest.java
Show resolved
Hide resolved
… to documentutils and add sanitizer for cbor
…otocol based parser not stateful
joewyz
force-pushed
the
joewyz/restjson11-protocol-test-fix
branch
from
0de15d4 to
d179735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiple changes:
__typeas the error's shapeId and different JSON protocols have different requirement for__type's format.With this fix, those protocol tests with
__typerequirement can pass.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.