Address comments

Author: joewyz

aws/client/aws-client-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJson11Protocol.java

@@ -25,7 +25,7 @@ public final class AwsJson11Protocol extends AwsJsonProtocol {
      *                discriminator of documents that use relative shape IDs.
      */
     public AwsJson11Protocol(ShapeId service) {
-        super(TRAIT_ID, service, ErrorTypeSanitizer::REMOVE_NAMESPACE_AND_URI);
+        super(TRAIT_ID, service, ErrorTypeSanitizer::removeNamespaceAndUri);
     }
 
     @Override

aws/client/aws-client-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJson1Protocol.java

@@ -25,7 +25,7 @@ public final class AwsJson1Protocol extends AwsJsonProtocol {
      *                discriminator of documents that use relative shape IDs.
      */
     public AwsJson1Protocol(ShapeId service) {
-        super(TRAIT_ID, service, ErrorTypeSanitizer::REMOVE_URI);
+        super(TRAIT_ID, service, ErrorTypeSanitizer::removeUri);
     }
 
     @Override

aws/client/aws-client-restjson/src/main/java/software/amazon/smithy/java/aws/client/restjson/RestJsonClientProtocol.java

@@ -53,7 +53,7 @@ public RestJsonClientProtocol(ShapeId service) {
                 .useJsonName(true)
                 .useTimestampFormat(true)
                 .defaultNamespace(service.getNamespace())
-                .errorTypeSanitizer(ErrorTypeSanitizer::REMOVE_NAMESPACE_AND_URI)
+                .errorTypeSanitizer(ErrorTypeSanitizer::removeNamespaceAndUri)
                 .build();
 
         this.errorDeserializer = HttpErrorDeserializer.builder()

codecs/json-codec/src/main/java/software/amazon/smithy/java/json/ErrorTypeSanitizer.java

@@ -13,7 +13,7 @@
  * sanitizers to remove trailing URIs or leading namespaces from {@code __type}.
  */
 public class ErrorTypeSanitizer {
-    public static String REMOVE_URI(String text) {
+    public static String removeUri(String text) {
         if (text == null) {
             return null;
         }
@@ -24,14 +24,14 @@ public static String REMOVE_URI(String text) {
         return text;
     }
 
-    public static String REMOVE_NAMESPACE_AND_URI(String text) {
+    public static String removeNamespaceAndUri(String text) {
         if (text == null) {
             return null;
         }
         var hash = text.indexOf('#');
         if (hash > 0) {
             text = text.substring(hash + 1);
         }
-        return REMOVE_URI(text);
+        return removeUri(text);
     }
 }

codecs/json-codec/src/main/java/software/amazon/smithy/java/json/JsonSettings.java

@@ -295,7 +295,7 @@ Builder overrideSerdeProvider(JsonSerdeProvider provider) {
          * @param errorTypeSanitizer the sanitizer to use for error type.
          * @return the builder.
          */
-        Builder errorTypeSanitizer(Function<String, String> errorTypeSanitizer) {
+        public Builder errorTypeSanitizer(Function<String, String> errorTypeSanitizer) {
             this.errorTypeSanitizer = errorTypeSanitizer;
             return this;
         }

codecs/json-codec/src/test/java/software/amazon/smithy/java/json/ErrorTypeSanitizerTest.java

@@ -0,0 +1,32 @@
+package software.amazon.smithy.java.json;
+
+import java.util.List;
+import org.junit.jupiter.api.Test;
+
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class ErrorTypeSanitizerTest {
+    private static final String SIMPLE_TYPE = "FooError";
+    private static final String TYPE_WITH_URI = "FooError:http://amazon.com/smithy/com.amazon.smithy.validate/";
+    private static final String TYPE_WITH_NAMESPACE = "aws.protocoltests.restjson#FooError";
+    private static final String TYPE_WITH_NAMESPACE_AND_URI = "aws.protocoltests.restjson#FooError:http://amazon.com/smithy/com.amazon.smithy.validate/";
+    @Test
+    public void testRemoveUri() {
+        String expected = "FooError";
+        String expectedWithNamespace = "aws.protocoltests.restjson#FooError";
+        assertEquals(expected, ErrorTypeSanitizer.removeUri(SIMPLE_TYPE));
+        assertEquals(expected, ErrorTypeSanitizer.removeUri(TYPE_WITH_URI));
+        assertEquals(expectedWithNamespace, ErrorTypeSanitizer.removeUri(TYPE_WITH_NAMESPACE));
+        assertEquals(expectedWithNamespace, ErrorTypeSanitizer.removeUri(TYPE_WITH_NAMESPACE_AND_URI));
+    }
+
+    @Test
+    public void testRemoveNameSpaceAndUri() {
+        String expected = "FooError";
+        assertEquals(expected, ErrorTypeSanitizer.removeNamespaceAndUri(SIMPLE_TYPE));
+        assertEquals(expected, ErrorTypeSanitizer.removeNamespaceAndUri(TYPE_WITH_URI));
+        assertEquals(expected, ErrorTypeSanitizer.removeNamespaceAndUri(TYPE_WITH_NAMESPACE));
+        assertEquals(expected, ErrorTypeSanitizer.removeNamespaceAndUri(TYPE_WITH_NAMESPACE_AND_URI));
+    }
+}