fix warning CA2254

Author: smdn

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi.Build/MSBuildExePath.cs

@@ -140,7 +140,7 @@ public static void EnsureSetEnvVar(ILogger logger = null)
     if (string.IsNullOrEmpty(Environment.GetEnvironmentVariable(MSBUILD_EXE_PATH)))
       Environment.SetEnvironmentVariable(MSBUILD_EXE_PATH, GetMSBuildExePath(out _));
 
-    logger?.LogDebug($"{MSBUILD_EXE_PATH}: {Environment.GetEnvironmentVariable(MSBUILD_EXE_PATH)}");
+    logger?.LogDebug("{MSBUILD_EXE_PATH}: {ENVVAR_MSBUILD_EXE_PATH}", MSBUILD_EXE_PATH, Environment.GetEnvironmentVariable(MSBUILD_EXE_PATH));
   }
 }
 #endif

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi.Build/ProjectBuilder.cs

@@ -53,14 +53,14 @@ public static IEnumerable<FileInfo> Build(
       globalProps["RuntimeIdentifier"] = options.RuntimeIdentifier;
 
     logger?.LogDebug("Build requested");
-    logger?.LogDebug($"  project: {projectFile}");
+    logger?.LogDebug("  project: {ProjectFile}", projectFile);
 
-    logger?.LogDebug($"  targets: {string.Join(";", options.TargetsToBuild)}");
+    logger?.LogDebug("  targets: {Targets}", string.Join(";", options.TargetsToBuild));
 
     logger?.LogDebug("  global properties:");
 
     foreach (var globalProp in globalProps) {
-      logger?.LogDebug($"    {globalProp.Key}: '{globalProp.Value}'");
+      logger?.LogDebug("    {GlobalPropKey}: '{GlobalPropValue}'", globalProp.Key, globalProp.Value);
     }
 
     var proj = new Project(
@@ -102,7 +102,7 @@ public static IEnumerable<FileInfo> Build(
           .Select(static item => item.GetMetadataValue("Identity"));
 
         foreach (var innerOutputFullPath in innerOutputFullPaths) {
-          logger?.LogDebug($"build output file: {innerOutputFullPath}");
+          logger?.LogDebug("build output file: {InnerOutputFullPath}", innerOutputFullPath);
 
           yield return new FileInfo(innerOutputFullPath);
         }
@@ -116,7 +116,7 @@ public static IEnumerable<FileInfo> Build(
             .Select(static item => item.GetMetadata("Identity"));
 
           foreach (var buildOutputFullPath in buildOutputFullPaths) {
-            logger?.LogDebug($"build output file: {buildOutputFullPath}");
+            logger?.LogDebug("build output file: {BuildOutputFullPath}", buildOutputFullPath);
 
             yield return new FileInfo(buildOutputFullPath);
           }

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi/ProjectFinder.cs

@@ -15,7 +15,7 @@ public static FileInfo FindSingleProjectOrSolution(
     ILogger logger = null
   )
   {
-    logger?.LogDebug($"finding project or solution from directory '{directory.FullName}'");
+    logger?.LogDebug("finding project or solution from directory '{Directory}'", directory.FullName);
 
     var solutionAndProjectFiles = directory
       .GetFiles("*.*", SearchOption.TopDirectoryOnly)
@@ -32,7 +32,7 @@ public static FileInfo FindSingleProjectOrSolution(
     if (first is null)
       throw new FileNotFoundException($"no solution or project file found in directory '{directory.FullName}'");
 
-    logger?.LogDebug($"found '{first.FullName}'");
+    logger?.LogDebug("found '{ProjectOrSolutionPath}'", first.FullName);
 
     return first;
   }

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi/RootCommandImplementation.cs

@@ -153,12 +153,14 @@ private static DirectoryInfo GetOutputDirectory(ParseResult parseResult)
 
   private void CommandMain(ParseResult parseResult, IConsole console)
   {
+#pragma warning disable CA2254
     logger?.LogDebug(parseResult.ToString());
+#pragma warning restore CA2254
 
     // ref: https://docs.microsoft.com/en-us/dotnet/core/dependency-loading/default-probing
-    logger?.LogDebug($"APP_PATHS={AppContext.GetData("APP_PATHS")}");
-    logger?.LogDebug($"APP_CONTEXT_DEPS_FILES={AppContext.GetData("APP_CONTEXT_DEPS_FILES")}");
-    logger?.LogDebug($"TRUSTED_PLATFORM_ASSEMBLIES={AppContext.GetData("TRUSTED_PLATFORM_ASSEMBLIES")}");
+    logger?.LogDebug("APP_PATHS={AppContext_APP_PATHS}", AppContext.GetData("APP_PATHS"));
+    logger?.LogDebug("APP_CONTEXT_DEPS_FILES={AppContext_APP_CONTEXT_DEPS_FILES}", AppContext.GetData("APP_CONTEXT_DEPS_FILES"));
+    logger?.LogDebug("TRUSTED_PLATFORM_ASSEMBLIES={AppContext_TRUSTED_PLATFORM_ASSEMBLIES}", AppContext.GetData("TRUSTED_PLATFORM_ASSEMBLIES"));
 
     var options = GetApiListWriterOptions(parseResult);
     var outputDirectory = GetOutputDirectory(parseResult);
@@ -192,8 +194,8 @@ private void CommandMain(ParseResult parseResult, IConsole console)
             writer.WriteAssemblyInfoHeader();
             writer.WriteExportedTypes();
 
-            arg.logger?.LogDebug($"generated API list {outputFilePath}");
-            arg.logger?.LogInformation($"{assm.Location} -> {outputFilePath}");
+            arg.logger?.LogDebug("generated API list {OutputFilePath}", outputFilePath);
+            arg.logger?.LogInformation("{AssemblyFilePath} -> {OutputFilePath}", assm.Location, outputFilePath);
 
             return outputFilePath;
           }
@@ -324,7 +326,7 @@ private IEnumerable<FileInfo> GetInputAssemblyFiles(ParseResult parseResult)
       throw new CommandOperationNotSupportedException($"unsupported input: {input}");
     }
 
-    logger?.LogDebug($"input file: '{inputFile.FullName}'");
+    logger?.LogDebug("input file: '{InputFilePath}'", inputFile.FullName);
 
     IEnumerable<FileInfo> inputAssemblyFiles = null;
 
@@ -358,7 +360,7 @@ private IEnumerable<FileInfo> GetInputAssemblyFiles(ParseResult parseResult)
 #endif
     }
     else {
-      logger?.LogWarning($"unknown type of file: {inputFile}");
+      logger?.LogWarning("unknown type of file: {InputFilePath}", inputFile);
 
       // try process as an assembly file
       inputAssemblyFiles = Enumerable.Repeat(inputFile, 1);