enable nullability annotations

Author: smdn

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi.Build/MSBuildExePath.cs

@@ -61,7 +61,7 @@ string path
     RegexOptions.Multiline | RegexOptions.CultureInvariant | RegexOptions.Compiled
   );
 
-  private static string GetSdkBasePath(out string sdkVersion)
+  private static string? GetSdkBasePath(out string? sdkVersion)
   {
     sdkVersion = default;
 
@@ -78,7 +78,7 @@ private static string GetSdkBasePath(out string sdkVersion)
     return null;
   }
 
-  private static string GetMSBuildExePath(out string sdkVersion)
+  private static string GetMSBuildExePath(out string? sdkVersion)
   {
 #if true
     sdkVersion = default;
@@ -134,7 +134,7 @@ string msbuildPath
 #endif
   }
 
-  public static void EnsureSetEnvVar(ILogger logger = null)
+  public static void EnsureSetEnvVar(ILogger? logger = null)
   {
     const string MSBUILD_EXE_PATH = nameof(MSBUILD_EXE_PATH);
 

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi.Build/ProjectBuilder.cs

@@ -21,18 +21,18 @@ public static class ProjectBuilder {
   public class Options {
     public const string DefaultConfiguration = "Debug";
 
-    public string Configuration { get; init; } = DefaultConfiguration;
-    public string TargetFramework { get; init; } = null;
-    // public string OS { get; init; }
-    public string RuntimeIdentifier { get; init; } = null;
-    public string[] TargetsToBuild { get; init; } = new[] { "Restore", "Build" };
+    public string? Configuration { get; init; } = DefaultConfiguration;
+    public string? TargetFramework { get; init; } = null;
+    // public string? OS { get; init; }
+    public string? RuntimeIdentifier { get; init; } = null;
+    public string[]? TargetsToBuild { get; init; } = new[] { "Restore", "Build" };
     public LoggerVerbosity LoggerVerbosity { get; init; } = LoggerVerbosity.Minimal;
   }
 
   public static IEnumerable<FileInfo> Build(
     FileInfo projectFile,
-    Options options = null,
-    Microsoft.Extensions.Logging.ILogger logger = null
+    Options? options = null,
+    Microsoft.Extensions.Logging.ILogger? logger = null
   )
   {
     if (projectFile is null)
@@ -56,7 +56,7 @@ public static IEnumerable<FileInfo> Build(
     logger?.LogDebug("Build requested");
     logger?.LogDebug("  project: {ProjectFile}", projectFile);
 
-    logger?.LogDebug("  targets: {Targets}", string.Join(";", options.TargetsToBuild));
+    logger?.LogDebug("  targets: {Targets}", string.Join(";", options.TargetsToBuild ?? Array.Empty<string>()));
 
     logger?.LogDebug("  global properties:");
 

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi.csproj

@@ -11,6 +11,7 @@ SPDX-License-Identifier: MIT
     <ToolCommandName>list-api</ToolCommandName>
     <VersionPrefix>1.1.0</VersionPrefix>
     <VersionSuffix></VersionSuffix>
+    <Nullable>enable</Nullable>
     <EnableFeature_BuildProjectFile Condition=" '$(Configuration)' != 'Release' ">true</EnableFeature_BuildProjectFile>
     <GeneratePackageReadmeFile>false</GeneratePackageReadmeFile>
     <DefineConstants

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi/Program.cs

@@ -12,7 +12,7 @@
 namespace Smdn.Reflection.ReverseGenerating.ListApi;
 
 internal class Program {
-  internal static string LoggerCategoryName => typeof(Program).Assembly.GetName().Name;
+  internal static string LoggerCategoryName => typeof(Program).Assembly.GetName().Name!;
 
   private static int Main(string[] args)
   {
@@ -30,13 +30,23 @@ private static int Main(string[] args)
       .UseDefaults()
       .UseExceptionHandler(
         onException: static (ex, context) => {
+          Exception? _ex = ex;
+
           if (ex is TargetInvocationException exTargetInvocation)
-            ex = exTargetInvocation.InnerException;
+            _ex = exTargetInvocation.InnerException;
+
+          switch (_ex) {
+            case InvalidCommandOperationException exInvalidCommandOperation:
+              Console.Error.WriteLine(exInvalidCommandOperation.Message);
+              break;
+
+            case CommandOperationNotSupportedException exCommandOperationNotSupported:
+              Console.Error.WriteLine(exCommandOperationNotSupported.Message);
+              break;
 
-          switch (ex) {
-            case InvalidCommandOperationException exInvalidCommandOperation: Console.Error.WriteLine(ex.Message); break;
-            case CommandOperationNotSupportedException exCommandOperationNotSupported: Console.Error.WriteLine(ex.Message); break;
-            default: Console.Error.WriteLine(ex); break;
+            default:
+              Console.Error.WriteLine(_ex);
+              break;
           }
         },
         errorExitCode: -1

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi/ProjectFinder.cs

@@ -14,7 +14,7 @@ namespace Smdn.Reflection.ReverseGenerating.ListApi;
 public static class ProjectFinder {
   public static FileInfo FindSingleProjectOrSolution(
     DirectoryInfo directory,
-    ILogger logger = null
+    ILogger? logger = null
   )
   {
     logger?.LogDebug("finding project or solution from directory '{Directory}'", directory.FullName);

src/Smdn.Reflection.ReverseGenerating.ListApi/Smdn.Reflection.ReverseGenerating.ListApi/RootCommandImplementation.cs

@@ -8,6 +8,9 @@
 using System.CommandLine.Builder;
 using System.CommandLine.Invocation;
 using System.CommandLine.Parsing;
+#if NULL_STATE_STATIC_ANALYSIS_ATTRIBUTES
+using System.Diagnostics.CodeAnalysis;
+#endif
 using System.IO;
 using System.Linq;
 using System.Reflection;
@@ -39,22 +42,22 @@ public class RootCommandImplementation {
     Arity = ArgumentArity.ExactlyOne,
   };
 
-  private static readonly Option<string> optionConfiguration = new(
+  private static readonly Option<string?> optionConfiguration = new(
     aliases: new[] { "-c", "--configuration" },
     description: "The 'build configuration' option passed to `Build` target when the project will be built.",
     getDefaultValue: static () => DefaultBuildConfiguration
   );
-  private static readonly Option<string> optionTargetFramework = new(
+  private static readonly Option<string?> optionTargetFramework = new(
     aliases: new[] { "-f", "--framework" },
     description: "The 'target framework' option passed to `Build` target when the project will be built.",
     getDefaultValue: static () => null
   );
-  private static readonly Option<string> optionRuntimeIdentifier = new(
+  private static readonly Option<string?> optionRuntimeIdentifier = new(
     aliases: new[] { "-r", "--runtime" },
     description: "The 'target runtime' option passed to `Build` target when the project will be built.",
     getDefaultValue: static () => null
   );
-  private static readonly Option<string> optionOS = new(
+  private static readonly Option<string?> optionOS = new(
     aliases: new[] { "--os" },
     description: "The 'target operating system' option passed to `Build` target when the project will be built.",
     getDefaultValue: static () => null
@@ -90,10 +93,10 @@ public class RootCommandImplementation {
     getDefaultValue: static () => false
   );
 
-  private readonly IServiceProvider serviceProvider;
-  private readonly Microsoft.Extensions.Logging.ILogger logger;
+  private readonly IServiceProvider? serviceProvider;
+  private readonly Microsoft.Extensions.Logging.ILogger? logger;
 
-  public RootCommandImplementation(IServiceProvider serviceProvider = null)
+  public RootCommandImplementation(IServiceProvider? serviceProvider = null)
   {
     this.serviceProvider = serviceProvider;
     this.logger = serviceProvider?.GetService<ILoggerFactory>()?.CreateLogger(Program.LoggerCategoryName);
@@ -236,7 +239,7 @@ public IEnumerable<string> GetOutputFilePaths(string[] args)
         logger: logger,
         context: out var context,
         actionWithLoadedAssembly: static (assm, outdir) => GetOutputFilePathOf(assm, outdir)
-      );
+      )!;
 
       // wait for the context to be collected
       if (context is null)
@@ -263,7 +266,7 @@ private static string GetOutputFilePathOf(Assembly assm, DirectoryInfo outputDir
 
     static string GetOutputFileName(Assembly a)
     {
-      var prefix = a.GetName().Name;
+      var prefix = a.GetName().Name!;
       var targetFramework = a.GetAssemblyMetadataAttributeValue<TargetFrameworkAttribute, string>();
 
       if (targetFramework is null)
@@ -280,7 +283,13 @@ static string GetOutputFileName(Assembly a)
       return $"{prefix}-{targetFramework}";
     }
 
-    static bool TryParseFrameworkName(string name, out FrameworkName frameworkName)
+    static bool TryParseFrameworkName(
+      string name,
+#if NULL_STATE_STATIC_ANALYSIS_ATTRIBUTES
+      [NotNullWhen(true)]
+#endif
+      out FrameworkName? frameworkName
+    )
     {
       frameworkName = default;
 
@@ -304,7 +313,7 @@ public IEnumerable<FileInfo> GetInputAssemblyFiles(string[] args)
   private IEnumerable<FileInfo> GetInputAssemblyFiles(ParseResult parseResult)
   {
     var input = parseResult.ValueForArgument(argumentInput);
-    FileInfo inputFile = null;
+    FileInfo inputFile;
 
     if (input is null)
       throw new CommandOperationNotSupportedException("input file or directory not specified");
@@ -330,7 +339,7 @@ private IEnumerable<FileInfo> GetInputAssemblyFiles(ParseResult parseResult)
 
     logger?.LogDebug("input file: '{InputFilePath}'", inputFile.FullName);
 
-    IEnumerable<FileInfo> inputAssemblyFiles = null;
+    IEnumerable<FileInfo> inputAssemblyFiles = Enumerable.Empty<FileInfo>();
 
     if (
       string.Equals(".dll", inputFile.Extension, StringComparison.OrdinalIgnoreCase) ||