fix(vscode): fix build and publish, reduce extension size (#2207)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: kermanx

eslint.config.js

@@ -20,10 +20,13 @@ export default antfu({
     'vue/no-v-text-v-html-on-component',
     'vue/component-name-in-template-casing',
     'jsonc/sort-array-values',
+    'pnpm/yaml-no-duplicate-catalog-item',
   )
   .override('antfu/pnpm/package-json', {
     ignores: [
       'packages/create-theme/template/package.json',
       'packages/create-app/template/package.json',
+      // VSCE and OVSX do not support pnpm catalog when reading `@types/vscode`'s version.
+      'packages/vscode/package.json',
     ],
   })

package.json

@@ -56,7 +56,7 @@
     "lint-staged": "catalog:dev",
     "mermaid": "catalog:frontend",
     "playwright-chromium": "catalog:dev",
-    "prettier": "catalog:frontend",
+    "prettier": "catalog:dev",
     "prettier-plugin-slidev": "catalog:dev",
     "rimraf": "catalog:dev",
     "shiki": "catalog:frontend",

packages/client/package.json

@@ -55,7 +55,6 @@
     "monaco-editor": "catalog:monaco",
     "nanotar": "catalog:frontend",
     "pptxgenjs": "catalog:prod",
-    "prettier": "catalog:frontend",
     "recordrtc": "catalog:frontend",
     "shiki": "catalog:frontend",
     "shiki-magic-move": "catalog:frontend",

packages/slidev/node/vite/extendConfig.ts

@@ -11,7 +11,6 @@ const INCLUDE_GLOBAL = [
   '@typescript/ata',
   'file-saver',
   'lz-string',
-  'prettier',
   'recordrtc',
   'typescript',
   'yaml',

packages/vscode/.vscodeignore

@@ -5,4 +5,8 @@ language-server/**
 scripts/**
 src/**
 tsdown.config.ts
-*.map
+**/*.map
+syntaxes/codeblock-patch.ts
+syntaxes/slidev.example.md
+syntaxes/tsconfig.json
+syntaxes/.vscode

packages/vscode/language-server/import-meta-url.ts

@@ -18,7 +18,7 @@
   "main": "./dist/index.cjs",
   "icon": "dist/res/logo.png",
   "engines": {
-    "vscode": "^1.89.0"
+    "vscode": "^1.99.0"
   },
   "activationEvents": [
     "onStartupFinished"
@@ -601,7 +601,7 @@
     "publish": "tsx scripts/publish.ts",
     "pack": "vsce package --no-dependencies",
     "prepare": "tsx scripts/schema.ts",
-    "build": "tsdown --env.NODE_ENV production --treeshake",
+    "build": "tsdown --env.NODE_ENV production --treeshake --minify",
     "dev": "nr prepare && tsdown --watch ./src --watch ./language-server --env.NODE_ENV development",
     "vscode:prepublish": "nr build"
   },
@@ -610,13 +610,13 @@
     "@slidev/parser": "workspace:*",
     "@slidev/types": "workspace:*",
     "@types/node": "catalog:types",
-    "@types/vscode": "catalog:types",
+    "@types/vscode": "^1.99.0",
     "@volar/language-server": "catalog:vscode",
     "@volar/vscode": "catalog:vscode",
     "get-port-please": "catalog:prod",
     "mlly": "catalog:prod",
     "ovsx": "catalog:dev",
-    "prettier": "catalog:frontend",
+    "prettier": "catalog:vscode",
     "reactive-vscode": "catalog:vscode",
     "tm-grammars": "catalog:frontend",
     "ts-json-schema-generator": "catalog:vscode",

packages/vscode/package.json

@@ -1,3 +1,4 @@
+import type { Options } from 'tinyexec'
 import fs from 'node:fs/promises'
 import process from 'node:process'
 import { x } from 'tinyexec'
@@ -23,11 +24,19 @@ async function publish() {
 
   console.log('Publishing VS Code extension...')
 
-  await x('npm', ['run', 'build'], { nodeOptions: { cwd: root, stdio: 'inherit' } })
+  const options: Partial<Options> = {
+    nodeOptions: {
+      cwd: root,
+      stdio: 'inherit',
+    },
+    throwOnError: true,
+  }
+
+  await x('npm', ['run', 'build'], options)
   console.log('\nPublish to VSCE...\n')
-  await x('npx', ['@vscode/vsce', 'publish', '--no-dependencies', '-p', process.env.VSCE_TOKEN!], { nodeOptions: { cwd: root, stdio: 'inherit' } })
+  await x('npx', ['@vscode/vsce', 'publish', '--no-dependencies', '-p', process.env.VSCE_TOKEN!], options)
   console.log('\nPublish to OVSE...\n')
-  await x('npx', ['ovsx', 'publish', '--no-dependencies', '-p', process.env.OVSX_TOKEN!], { nodeOptions: { cwd: root, stdio: 'inherit' } })
+  await x('npx', ['ovsx', 'publish', '--no-dependencies', '-p', process.env.OVSX_TOKEN!], options)
 }
 
 publish()

packages/vscode/scripts/publish.ts

@@ -1,9 +1,4 @@
-import { readFileSync } from 'node:fs'
-import { join } from 'node:path'
-
-const Markdown = JSON.parse(
-  readFileSync(join(import.meta.dirname, '../node_modules/tm-grammars/grammars/markdown.json'), 'utf8'),
-)
+import Markdown from 'tm-grammars/grammars/markdown.json' with { type: 'json' }
 
 const base = {
   $schema: 'https://raw.githubusercontent.com/martinring/tmlanguage/master/tmlanguage.json',

packages/vscode/syntaxes/codeblock-patch.ts

@@ -1,4 +1,5 @@
-import { copyFileSync, existsSync, mkdirSync, writeFileSync } from 'node:fs'
+import { existsSync } from 'node:fs'
+import { copyFile, mkdir, writeFile } from 'node:fs/promises'
 import { join } from 'node:path'
 import process from 'node:process'
 import { fileURLToPath } from 'node:url'
@@ -7,51 +8,51 @@ import { defineConfig } from 'tsdown'
 import { generateCodeblockPatch } from './syntaxes/codeblock-patch.ts'
 
 export default defineConfig({
-  // @ts-expect-error `entry` is valid option
   entry: {
     'index': 'src/index.ts',
     'language-server': 'language-server/bin.ts',
   },
   format: 'cjs',
-  target: 'node18',
+  target: 'node20',
   clean: true,
   minify: process.env.NODE_ENV === 'production',
   sourcemap: true,
   external: [
     'vscode',
   ],
-  shims: ['./language-server/import-meta-url.ts'],
-  define: {
-    'import.meta.url': 'import_meta_url',
-  },
   alias: {
     '@slidev/parser/fs': fileURLToPath(new URL('../parser/src/fs.ts', import.meta.url)),
     '@slidev/parser/core': fileURLToPath(new URL('../parser/src/core.ts', import.meta.url)),
     '@slidev/parser/types': fileURLToPath(new URL('../parser/src/types.ts', import.meta.url)),
     '@slidev/parser': fileURLToPath(new URL('../parser/src/index.ts', import.meta.url)),
   },
-  plugins: [{
-    name: 'umd2esm',
-    setup(build: any) {
-      build.onResolve({ filter: /^(vscode-.*-languageservice|jsonc-parser)/ }, async (args: any) => {
-        const pathUmdMay = await resolvePath(args.path, { url: args.resolveDir })
-        // Call twice the replace is to solve the problem of the path in Windows
-        const pathEsm = pathUmdMay.replace('/umd/', '/esm/').replace('\\umd\\', '\\esm\\')
-        return { path: pathEsm }
-      })
+  plugins: [
+    {
+      name: 'umd2esm',
+      resolveId: {
+        filter: {
+          id: /^(vscode-.*-languageservice|vscode-languageserver-types|jsonc-parser)/,
+        },
+        async handler(source, importer) {
+          const pathUmdMay = await resolvePath(source, { url: importer })
+          // Call twice the replace is to solve the problem of the path in Windows
+          const pathEsm = pathUmdMay.replace('/umd/', '/esm/').replace('\\umd\\', '\\esm\\')
+          return { id: pathEsm }
+        },
+      },
     },
-  }],
+  ],
   async onSuccess() {
     const assetsDir = join(import.meta.dirname, '../../assets')
     const resDir = join(import.meta.dirname, './dist/res')
 
     if (!existsSync(resDir))
-      mkdirSync(resDir, { recursive: true })
+      await mkdir(resDir, { recursive: true })
 
     for (const file of ['logo-mono.svg', 'logo-mono-dark.svg', 'logo.png', 'logo.svg'])
-      copyFileSync(join(assetsDir, file), join(resDir, file))
+      await copyFile(join(assetsDir, file), join(resDir, file))
 
-    writeFileSync(
+    await writeFile(
       join(import.meta.dirname, 'syntaxes/codeblock-patch.json'),
       JSON.stringify(generateCodeblockPatch(), null, 2),
     )