[ENH] Generate synthetic stallion data for testing. #1999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #1840 by replacing the get_stallion_data which downloads the dataset with a function which generates a similar dataset for testing.
Reference Issues/PRs
#1840
What does this implement/fix? Explain your changes.
Replace get_stallion_data usage in tests with get_stallion_dummy_data to avoid repeated network downloads and support offline CI.
What should a reviewer concentrate their feedback on?
Is this the right approach for generating synthetic data for tests ?
Did you add any tests for the change?
No
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files