Add test for allowUndefinedVariablesInFileScope

Author: sirbrillig

Tests/VariableAnalysisSniff/GlobalScopeTest.php

@@ -0,0 +1,41 @@
+<?php
+namespace VariableAnalysis\Tests\VariableAnalysisSniff;
+
+use VariableAnalysis\Tests\BaseTestCase;
+
+class GlobalScopeTest extends BaseTestCase {
+  public function testGlobalScopeWarnings() {
+    $fixtureFile = $this->getFixture('GlobalScopeFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->ruleset->setSniffProperty(
+      'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
+      'allowUndefinedVariablesInFileScope',
+      'false'
+    );
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedErrors = [
+      4,
+      7,
+      10,
+    ];
+    $this->assertEquals($expectedErrors, $lines);
+  }
+
+  public function testGlobalScopeWarningsWithAllowUndefinedVariablesInFileScope() {
+    $fixtureFile = $this->getFixture('GlobalScopeFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->ruleset->setSniffProperty(
+      'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
+      'allowUndefinedVariablesInFileScope',
+      'true'
+    );
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedErrors = [
+      4,
+      10,
+    ];
+    $this->assertEquals($expectedErrors, $lines);
+  }
+}

Tests/VariableAnalysisSniff/fixtures/GlobalScopeFixture.php

@@ -0,0 +1,11 @@
+<?php
+
+$name = 'friend';
+$place = 'faerie'; // unused variable $place
+
+echo $name;
+echo $activity; // undefined variable $activity
+
+function thisIsAFunction() {
+    echo $whatever; // undefined variable $whatever
+}