Skip to content

Server config checks shouldn't be required in offline mode #672

@wk9874

Description

@wk9874

In offline mode, you are still required to enter the server URL and token (lines 216 - 220 of simvue/config/user.py) - these shouldnt be required in offline mode.

Even if you do specify these, the code currently still performs a check of their validity in check_valid_server - this will fail in the case of no internet connection. It currently uses mode to define when to skip this check, but that parameter is only defined in the higher level API, not the lower level one. Meaning if you do eg Tag.new(offline=True), it wont pop 'mode' in line 154 of base.py, and therefore will treat it as an online run.

Metadata

Metadata

Assignees

Labels

ready for testingThis issue has been fixed and is ready for testing

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions