Fixing Avx2 tests (#38)

---------

Co-authored-by: Daniel Lemire <dlemire@lemire.me>

Author: lemire

README.md

@@ -30,6 +30,11 @@ dotnet test
 
 To see which tests are running, we recommend setting the verbosity level:
 
+```
+dotnet test -v=normal
+```
+
+More details could be useful:
 ```
 dotnet test -v d
 ```
@@ -89,7 +94,6 @@ dotnet build
 We recommend you use `dotnet format`. E.g.,
 
 ```
-cd test
 dotnet format
 ```
 

benchmark/Benchmark.cs

@@ -27,13 +27,17 @@ public class Speed : IColumn
     {
         public string GetValue(Summary summary, BenchmarkCase benchmarkCase)
         {
+            if (summary is null || benchmarkCase is null || benchmarkCase.Parameters is null)
+            {
+                return "N/A";
+            }
             var ourReport = summary.Reports.First(x => x.BenchmarkCase.Equals(benchmarkCase));
             var fileName = (string)benchmarkCase.Parameters["FileName"];
-            long length = new System.IO.FileInfo(fileName).Length;
-            if (ourReport.ResultStatistics is null)
+            if (ourReport is null || ourReport.ResultStatistics is null)
             {
                 return "N/A";
             }
+            long length = new System.IO.FileInfo(fileName).Length;
             var mean = ourReport.ResultStatistics.Mean;
             return $"{(length / ourReport.ResultStatistics.Mean):#####.00}";
         }
@@ -57,8 +61,8 @@ public string GetValue(Summary summary, BenchmarkCase benchmarkCase)
     [Config(typeof(Config))]
     public class RealDataBenchmark
     {
-
-        private class Config : ManualConfig
+#pragma warning disable CA1812
+        private sealed class Config : ManualConfig
         {
             public Config()
             {
@@ -67,6 +71,7 @@ public Config()
 
                 if (RuntimeInformation.ProcessArchitecture == Architecture.Arm64)
                 {
+#pragma warning disable CA1303
                     Console.WriteLine("ARM64 system detected.");
                     AddFilter(new AnyCategoriesFilter(["arm64", "scalar", "runtime"]));
 
@@ -75,21 +80,25 @@ public Config()
                 {
                     if (Vector512.IsHardwareAccelerated && System.Runtime.Intrinsics.X86.Avx512Vbmi.IsSupported)
                     {
+#pragma warning disable CA1303
                         Console.WriteLine("X64 system detected (Intel, AMD,...) with AVX-512 support.");
                         AddFilter(new AnyCategoriesFilter(["avx512", "avx", "sse", "scalar", "runtime"]));
                     }
                     else if (Avx2.IsSupported)
                     {
+#pragma warning disable CA1303
                         Console.WriteLine("X64 system detected (Intel, AMD,...) with AVX2 support.");
                         AddFilter(new AnyCategoriesFilter(["avx", "sse", "scalar", "runtime"]));
                     }
                     else if (Ssse3.IsSupported)
                     {
+#pragma warning disable CA1303
                         Console.WriteLine("X64 system detected (Intel, AMD,...) with Sse4.2 support.");
                         AddFilter(new AnyCategoriesFilter(["sse", "scalar", "runtime"]));
                     }
                     else
                     {
+#pragma warning disable CA1303
                         Console.WriteLine("X64 system detected (Intel, AMD,...) without relevant SIMD support.");
                         AddFilter(new AnyCategoriesFilter(["scalar", "runtime"]));
                     }
@@ -131,13 +140,13 @@ public Config()
                 @"data/turkish.utf8.txt",
                 @"data/vietnamese.utf8.txt")]
         public string? FileName;
-        public byte[] allLinesUtf8 = new byte[0];
+        private byte[] allLinesUtf8 = Array.Empty<byte>();
 
 
         public unsafe delegate byte* Utf8ValidationFunction(byte* pUtf8, int length);
         public unsafe delegate byte* DotnetRuntimeUtf8ValidationFunction(byte* pUtf8, int length, out int utf16CodeUnitCountAdjustment, out int scalarCountAdjustment);
 
-        public void RunUtf8ValidationBenchmark(byte[] data, Utf8ValidationFunction validationFunction)
+        private void RunUtf8ValidationBenchmark(byte[] data, Utf8ValidationFunction validationFunction)
         {
             unsafe
             {
@@ -152,7 +161,7 @@ public void RunUtf8ValidationBenchmark(byte[] data, Utf8ValidationFunction valid
             }
         }
 
-        public void RunDotnetRuntimeUtf8ValidationBenchmark(byte[] data, DotnetRuntimeUtf8ValidationFunction validationFunction)
+        private void RunDotnetRuntimeUtf8ValidationBenchmark(byte[] data, DotnetRuntimeUtf8ValidationFunction validationFunction)
         {
             unsafe
             {
@@ -229,18 +238,18 @@ public unsafe void SIMDUtf8ValidationRealDataArm64()
 
         [Benchmark]
         [BenchmarkCategory("avx")]
-         public unsafe void SIMDUtf8ValidationRealDataAvx2()
-         {
-             if (allLinesUtf8 != null)
-             {
+        public unsafe void SIMDUtf8ValidationRealDataAvx2()
+        {
+            if (allLinesUtf8 != null)
+            {
                 RunUtf8ValidationBenchmark(allLinesUtf8, (byte* pInputBuffer, int inputLength) =>
                 {
                     int dummyUtf16CodeUnitCountAdjustment, dummyScalarCountAdjustment;
                     // Call the method with additional out parameters within the lambda.
                     // You must handle these additional out parameters inside the lambda, as they cannot be passed back through the delegate.
                     return SimdUnicode.UTF8.GetPointerToFirstInvalidByteAvx2(pInputBuffer, inputLength, out dummyUtf16CodeUnitCountAdjustment, out dummyScalarCountAdjustment);
                 });
-             }
+            }
         }
 
         [Benchmark]

src/Ascii.cs

@@ -25,6 +25,7 @@ public unsafe static class Ascii
 
         public static bool IsAscii(this string s)
         {
+            if (s == null) return true;
             foreach (var c in s)
             {
                 if (!c.IsAscii()) return false;