SetResult may deadlock if executed non-async

Trolldemorted · Trolldemorted · commit dbc9cb663d5d · 2018-07-06T15:56:58.000+02:00
diff --git a/libsignal-service-dotnet/websocket/SignalWebSocketConnection.cs b/libsignal-service-dotnet/websocket/SignalWebSocketConnection.cs
@@ -67,7 +67,9 @@ private void SignalWebSocket_MessageReceived(object sender, SignalWebSocketMessa
                     OutgoingRequests.TryGetValue(msg.Response.Id, out TaskCompletionSource<(uint, string)> savedRequest);
                     if (savedRequest != null)
                     {
-                        savedRequest.SetResult((msg.Response.Status, Encoding.UTF8.GetString(msg.Response.Body.ToByteArray())));
+                        Task.Run(() => {
+                            savedRequest.SetResult((msg.Response.Status, Encoding.UTF8.GetString(msg.Response.Body.ToByteArray())));
+                        });
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,9 @@ private void SignalWebSocket_MessageReceived(object sender, SignalWebSocketMessa`
`67`	`67`	`OutgoingRequests.TryGetValue(msg.Response.Id, out TaskCompletionSource<(uint, string)> savedRequest);`
`68`	`68`	`if (savedRequest != null)`
`69`	`69`	`{`
`70`		`- savedRequest.SetResult((msg.Response.Status, Encoding.UTF8.GetString(msg.Response.Body.ToByteArray())));`
	`70`	`+ Task.Run(() => {`
	`71`	`+ savedRequest.SetResult((msg.Response.Status, Encoding.UTF8.GetString(msg.Response.Body.ToByteArray())));`
	`72`	`+ });`
`71`	`73`	`}`
`72`	`74`	`}`
`73`	`75`	`}`