Skip to content

Commit 24c93f0

Browse files
justin808claude
andcommitted
Fix pnpm frozen-lockfile for minimum dependency config
The minimum config job switches shakapacker from 9.4.0 to 8.2.0 via bin/ci-switch-config, which modifies package.json. This causes pnpm-lock.yaml to be out of sync, requiring --no-frozen-lockfile. Added conditional --no-frozen-lockfile flag to dummy app pnpm install steps when running with minimum dependency level. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 340aa57 commit 24c93f0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/integration-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ jobs:
154154
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
155155
- name: Install Node modules with pnpm for dummy app
156156
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
157-
# The dummy app doesn't have a pnpm-lock.yaml and shouldn't use frozen lockfile
158-
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace
157+
# minimum config changes package.json (shakapacker version), so can't use frozen lockfile
158+
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
159159
- name: Save dummy app ruby gems to cache
160160
uses: actions/cache@v4
161161
with:
@@ -261,8 +261,8 @@ jobs:
261261
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
262262
- name: Install Node modules with pnpm for dummy app
263263
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
264-
# The dummy app doesn't have a pnpm-lock.yaml and shouldn't use frozen lockfile
265-
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace
264+
# minimum config changes package.json (shakapacker version), so can't use frozen lockfile
265+
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
266266
- name: Dummy JS tests
267267
run: |
268268
cd react_on_rails/spec/dummy

0 commit comments

Comments
 (0)