Skip to content

Commit 086b910

Browse files
committed
Unify config further
1 parent 6fcb884 commit 086b910

File tree

3 files changed

+9
-16
lines changed

3 files changed

+9
-16
lines changed

.rubocop.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ Style/HashTransformValues:
5555
Metrics/AbcSize:
5656
Max: 28
5757

58+
Metrics/ClassLength:
59+
Max: 150
60+
61+
Metrics/CyclomaticComplexity:
62+
Max: 8
63+
5864
Metrics/PerceivedComplexity:
5965
Max: 10
6066

@@ -86,5 +92,8 @@ RSpec/MultipleExpectations:
8692
RSpec/MultipleMemoizedHelpers:
8793
Max: 12
8894

95+
RSpec/NestedGroups:
96+
Max: 5
97+
8998
Style/FrozenStringLiteralComment:
9099
EnforcedStyle: always

react_on_rails/.rubocop.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,7 @@ Metrics/AbcSize:
2626
Exclude:
2727
- 'lib/generators/react_on_rails/install_generator.rb' # Generator setup methods require comprehensive error handling
2828

29-
Metrics/CyclomaticComplexity:
30-
Max: 7
31-
3229
Metrics/ClassLength:
33-
Max: 150
3430
Exclude:
3531
- 'lib/generators/react_on_rails/base_generator.rb' # Generator complexity justified
3632
- 'lib/react_on_rails/dev/server_manager.rb' # Dev tool with comprehensive help system
@@ -54,9 +50,6 @@ RSpec/AnyInstance:
5450
- 'spec/react_on_rails/binstubs/dev_static_spec.rb'
5551
- 'spec/react_on_rails/dev/**/*_spec.rb' # Dev module tests require system mocking
5652

57-
RSpec/NestedGroups:
58-
Max: 4
59-
6053
RSpec/BeforeAfterAll:
6154
Exclude:
6255
- 'spec/react_on_rails/generators/dev_tests_generator_spec.rb'

react_on_rails_pro/.rubocop.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,6 @@ AllCops:
1212
- 'spec/dummy/bin/**/*'
1313
- 'bin/**/*'
1414

15-
Metrics/CyclomaticComplexity:
16-
Max: 8
17-
18-
Metrics/ClassLength:
19-
Max: 140
20-
21-
RSpec/NestedGroups:
22-
Max: 5
23-
2415
RSpec/BeforeAfterAll:
2516
Exclude:
2617
- 'spec/react_on_rails/generators/dev_tests_generator_spec.rb'

0 commit comments

Comments
 (0)