Attempt to appease the linter.

Author: nachogiljaldo

error.go

@@ -34,7 +34,7 @@ const (
 	NotEnoughReplicas                  Error = 19
 	NotEnoughReplicasAfterAppend       Error = 20
 	InvalidRequiredAcks                Error = 21
-	IllegalGeneration                  Error = 22
+	IllegalGenerationErr               Error = 22
 	InconsistentGroupProtocol          Error = 23
 	InvalidGroupId                     Error = 24
 	UnknownMemberId                    Error = 25
@@ -217,7 +217,7 @@ func (e Error) Title() string {
 		return "Not Enough Replicas After Append"
 	case InvalidRequiredAcks:
 		return "Invalid Required Acks"
-	case IllegalGeneration:
+	case IllegalGenerationErr:
 		return "Illegal Generation"
 	case InconsistentGroupProtocol:
 		return "Inconsistent Group Protocol"
@@ -426,7 +426,7 @@ func (e Error) Description() string {
 		return "the message was written to the log, but with fewer in-sync replicas than required."
 	case InvalidRequiredAcks:
 		return "the requested requiredAcks is invalid (anything other than -1, 1, or 0)"
-	case IllegalGeneration:
+	case IllegalGenerationErr:
 		return "the generation id provided in the request is not the current generation"
 	case InconsistentGroupProtocol:
 		return "the member provided a protocol type or set of protocols which is not compatible with the current group"

error_test.go

@@ -28,7 +28,7 @@ func TestError(t *testing.T) {
 		NotEnoughReplicas,
 		NotEnoughReplicasAfterAppend,
 		InvalidRequiredAcks,
-		IllegalGeneration,
+		IllegalGenerationErr,
 		InconsistentGroupProtocol,
 		InvalidGroupId,
 		UnknownMemberId,

reader.go

@@ -164,7 +164,7 @@ func (r *Reader) commitOffsetsWithRetry(gen *Generation, offsetStash offsetStash
 			msgsForPartition[partition] = commitInfo.offset
 		}
 	}
-	var illegalGenerationErr error
+	var illegalGenerationErr bool
 	for generationID, messages := range messagesToSendForGeneration {
 		for attempt := 0; attempt < retries; attempt++ {
 			if attempt != 0 {
@@ -173,25 +173,24 @@ func (r *Reader) commitOffsetsWithRetry(gen *Generation, offsetStash offsetStash
 				}
 			}
 
-			if commitErr := gen.CommitOffsetsForGenID(generationID, messages); commitErr == nil {
+			if err = gen.CommitOffsetsForGenID(generationID, messages); err == nil {
 				continue
-			} else {
-				// IllegalGeneration error is not retriable, but we should attempt to
-				// perform the remaining commits
-				if commitErr == IllegalGeneration {
-					r.withErrorLogger(func(l Logger) { l.Printf("%v", commitErr) })
-					illegalGenerationErr = commitErr
-					offsetStash.removeGenerationID(generationID)
-				} else {
-					err = commitErr
-				}
+			}
+
+			// IllegalGeneration error is not retriable, but we should attempt to
+			// perform the remaining commits
+			if err == IllegalGenerationErr {
+				r.withErrorLogger(func(l Logger) { l.Printf("%v", err) })
+				illegalGenerationErr = true
+				err = nil
+				offsetStash.removeGenerationID(generationID)
 			}
 		}
 	}
 
 	// if configured to ignore the error
-	if illegalGenerationErr != nil && r.config.ErrorOnWrongGenerationCommit {
-		err = illegalGenerationErr
+	if illegalGenerationErr && r.config.ErrorOnWrongGenerationCommit {
+		err = IllegalGenerationErr
 	}
 	return // err will not be nil
 }

reader_test.go

@@ -1261,7 +1261,7 @@ func testReaderConsumerGroupRebalanceDoesNotCommitNotOwnedPartitions(t *testing.
 	require.NoError(t, secondReader.CommitMessages(ctx, msgsForSecondReader...))
 
 	// commit all messages the first reader received, we expect an error
-	require.ErrorIs(t, IllegalGeneration, firstReader.CommitMessages(ctx, allMessages...))
+	require.ErrorIs(t, IllegalGenerationErr, firstReader.CommitMessages(ctx, allMessages...))
 
 	// verify that no offsets have been altered
 	require.Eventually(t, func() bool {