Skip to content

Commit cf75105

Browse files
authored
Segmentio: RIP json3 (#553)
* Remove JSON3 * Use smaller uuid package * Bump patch version * Remove more JSON3 refs * Bump patch versions * Update libraries that depend on json3
1 parent 87d5673 commit cf75105

File tree

15 files changed

+73
-35
lines changed

15 files changed

+73
-35
lines changed

integrations/extole/lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ var domify = require('domify');
88
var each = require('@ndhoule/each');
99
var extend = require('@ndhoule/extend');
1010
var integration = require('@segment/analytics.js-integration');
11-
var json = require('json3');
11+
var json = JSON;
1212

1313
/**
1414
* Expose `Extole` integration.

integrations/extole/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-extole",
33
"description": "The Extole analytics.js integration.",
4-
"version": "2.0.0",
4+
"version": "2.0.1",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -27,8 +27,7 @@
2727
"@ndhoule/each": "^2.0.1",
2828
"@ndhoule/extend": "^2.0.0",
2929
"@segment/analytics.js-integration": "^2.1.0",
30-
"domify": "^1.4.0",
31-
"json3": "^3.3.2"
30+
"domify": "^1.4.0"
3231
},
3332
"devDependencies": {
3433
"@segment/analytics.js-core": "^3.0.0",

integrations/intercom/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-intercom",
33
"description": "The Intercom analytics.js integration.",
4-
"version": "3.0.0",
4+
"version": "3.0.1",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -34,7 +34,6 @@
3434
"@segment/convert-dates": "^1.0.0",
3535
"flat": "2.0.1",
3636
"is": "^3.1.0",
37-
"json3": "^3.3.2",
3837
"obj-case": "^0.2.0"
3938
},
4039
"devDependencies": {

integrations/parsely/lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
var integration = require('@segment/analytics.js-integration');
88
var when = require('do-when');
99
var reject = require('reject');
10-
var json = require('json3');
10+
var json = JSON;
1111
var is = require('is');
1212
var defaults = require('@ndhoule/defaults');
1313

integrations/parsely/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-parsely",
33
"description": "The Parsely analytics.js integration.",
4-
"version": "2.3.1",
4+
"version": "2.3.2",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -30,7 +30,6 @@
3030
"array-filter": "^1.0.0",
3131
"do-when": "^1.0.0",
3232
"is": "3.2.1",
33-
"json3": "^3.3.2",
3433
"reject": "0.0.1"
3534
},
3635
"devDependencies": {

integrations/parsely/test/index.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ var filter = require('array-filter');
77
var integration = require('@segment/analytics.js-integration');
88
var sandbox = require('@segment/clear-env');
99
var tester = require('@segment/analytics.js-integration-tester');
10-
var json = require('json3');
10+
var json = JSON;
1111

1212
describe('Parsely', function() {
1313
var analytics;

integrations/segmentio/lib/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,17 @@ var clone = require('component-clone');
99
var cookie = require('component-cookie');
1010
var extend = require('@ndhoule/extend');
1111
var integration = require('@segment/analytics.js-integration');
12-
var json = require('json3');
1312
var keys = require('@ndhoule/keys');
1413
var localstorage = require('yields-store');
1514
var protocol = require('@segment/protocol');
1615
var send = require('@segment/send-json');
1716
var topDomain = require('@segment/top-domain');
1817
var utm = require('@segment/utm-params');
19-
var uuid = require('uuid').v4;
18+
var uuid = require('@lukeed/uuid').v4;
2019
var Queue = require('@segment/localstorage-retry');
2120

21+
const json = JSON;
22+
2223
/**
2324
* Cookie options
2425
*/

integrations/segmentio/package.json

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-segmentio",
33
"description": "The Segmentio analytics.js integration.",
4-
"version": "4.3.0",
4+
"version": "4.3.1",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -28,24 +28,22 @@
2828
"@ndhoule/keys": "^2.0.0",
2929
"@segment/ad-params": "^1.0.0",
3030
"@segment/analytics.js-integration": "^2.1.0",
31-
"@segment/localstorage-retry": "^1.2.2",
31+
"@segment/localstorage-retry": "^1.2.5",
3232
"@segment/protocol": "^1.0.0",
33-
"@segment/send-json": "^3.0.0",
33+
"@segment/send-json": "^4.0.2",
3434
"@segment/top-domain": "^3.0.0",
3535
"@segment/utm-params": "^2.0.0",
3636
"component-clone": "^0.2.2",
3737
"component-cookie": "^1.1.2",
3838
"component-type": "^1.2.1",
39-
"json3": "^3.3.2",
40-
"uuid": "^2.0.2",
39+
"@lukeed/uuid": "^2.0.0",
4140
"yields-store": "^1.0.2"
4241
},
4342
"devDependencies": {
4443
"@segment/analytics.js-core": "^3.8.0",
4544
"@segment/analytics.js-integration-tester": "^2.0.0",
4645
"@segment/clear-env": "^2.0.0",
4746
"browserify": "^16.2.3",
48-
"eslint": "^5.16.0",
4947
"karma": "^4.1.0",
5048
"karma-browserify": "^6.0.0",
5149
"karma-chrome-launcher": "^2.2.0",
@@ -55,8 +53,8 @@
5553
"karma-spec-reporter": "^0.0.32",
5654
"karma-summary-reporter": "^1.6.0",
5755
"mocha": "^6.1.4",
58-
"watchify": "^3.11.1",
5956
"proclaim": "^3.4.1",
60-
"sinon": "^1.17.4"
57+
"sinon": "^1.17.4",
58+
"watchify": "^3.11.1"
6159
}
6260
}

integrations/segmentio/test/index.test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
var Analytics = require('@segment/analytics.js-core').constructor;
4-
var JSON = require('json3');
54
var Segment = require('../lib/');
65
var assert = require('proclaim');
76
var cookie = require('component-cookie');

integrations/tvsquared/lib/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
var JSON = require('json3');
43
var integration = require('@segment/analytics.js-integration');
54
var useHttps = require('use-https');
65

0 commit comments

Comments
 (0)