Skip to content

Commit 254bd7e

Browse files
authored
[STRATCONN-182]AA-Allow event name to be sent as context data variable (#472)
* Add event names to top level property list * Update unit tests * Update HISTORY.md and package.json
1 parent e0706ae commit 254bd7e

File tree

4 files changed

+30
-14
lines changed

4 files changed

+30
-14
lines changed

integrations/adobe-analytics/HISTORY.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
1.16.1 / 2020-05-15
2+
===================
3+
* Supports sending top level `event` as `prop`, `eVar`, `lVar`, `hVar`, or Context Data Variable.
4+
15
1.16.0 / 2020-05-05
26
===================
37
* Supports sending top level `messageId` and `anonymousId` as `prop`, `eVar`, `lVar`, `hVar`, or Context Data Variable.

integrations/adobe-analytics/lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ function extractProperties(facade, options, propType) {
821821
options.contextValues
822822
];
823823

824-
var topLevelProperties = ['messageId', 'anonymousId'];
824+
var topLevelProperties = ['messageId', 'anonymousId', 'event'];
825825

826826
var props = facade.properties();
827827
if (propType === 'mergedPropContext') {

integrations/adobe-analytics/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-adobe-analytics",
33
"description": "The Adobe Analytics analytics.js integration.",
4-
"version": "1.16.0",
4+
"version": "1.16.1",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

integrations/adobe-analytics/test/index.test.js

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -229,22 +229,25 @@ describe('Adobe Analytics', function() {
229229
analytics.called(window.s.tl, true, 'o', 'Overlord exploded');
230230
});
231231

232-
it('should track set top level fields (msgId and anonId) set as eVars properly', function() {
232+
it('should track set top level fields (msgId, anonId, event) set as eVars properly', function() {
233233
adobeAnalytics.options.eVars = {
234234
messageId: 'eVar2',
235-
anonymousId: 'eVar3'
235+
anonymousId: 'eVar3',
236+
event: 'eVar4'
236237
};
237238
analytics.track('Overlord exploded');
238239
analytics.equal(window.s.events, 'event7');
239240
analytics.assert(window.s.eVar2);
240241
analytics.assert(window.s.eVar3);
242+
analytics.assert(window.s.eVar4);
241243
analytics.assert(
242244
contains(
243245
window.s.linkTrackVars,
244246
'events',
245247
'timestamp',
246248
'eVar2',
247-
'eVar3'
249+
'eVar3',
250+
'eVar4'
248251
)
249252
);
250253
analytics.called(window.s.tl, true, 'o', 'Overlord exploded');
@@ -275,22 +278,25 @@ describe('Adobe Analytics', function() {
275278
analytics.called(window.s.tl, true, 'o', 'Drank Some Milk');
276279
});
277280

278-
it('should track set top level fields (msgId and anonId) set as props properly', function() {
281+
it('should track set top level fields (msgId, anonId, event) set as props properly', function() {
279282
adobeAnalytics.options.eVars = {
280283
messageId: 'prop1',
281-
anonymousId: 'prop2'
284+
anonymousId: 'prop2',
285+
event: 'prop3'
282286
};
283287
analytics.track('Overlord exploded');
284288
analytics.equal(window.s.events, 'event7');
285289
analytics.assert(window.s.prop1);
286290
analytics.assert(window.s.prop2);
291+
analytics.assert(window.s.prop3);
287292
analytics.assert(
288293
contains(
289294
window.s.linkTrackVars,
290295
'events',
291296
'timestamp',
292297
'prop1',
293-
'prop2'
298+
'prop2',
299+
'prop3'
294300
)
295301
);
296302
analytics.called(window.s.tl, true, 'o', 'Overlord exploded');
@@ -314,14 +320,16 @@ describe('Adobe Analytics', function() {
314320
analytics.called(window.s.tl);
315321
});
316322

317-
it('should send top level fields (msgId & anonId) as context properties', function() {
323+
it('should send top level fields (msgId, anonId, event) as context properties', function() {
318324
adobeAnalytics.options.contextValues = {
319325
messageId: 'messageIdAdobe',
320-
anonymousId: 'anonymousIdAdobe'
326+
anonymousId: 'anonymousIdAdobe',
327+
event: 'adobeEvent'
321328
};
322329
analytics.track('Drank Some Milk', { foo: 'bar' });
323330
analytics.assert(window.s.contextData.messageIdAdobe);
324331
analytics.assert(window.s.contextData.anonymousIdAdobe);
332+
analytics.assert(window.s.contextData.adobeEvent);
325333
analytics.called(window.s.tl);
326334
});
327335

@@ -1203,10 +1211,11 @@ describe('Adobe Analytics', function() {
12031211
analytics.called(window.s.t);
12041212
});
12051213

1206-
it('tracks top level fields (msgId & anonId) as mapped properties', function() {
1214+
it('tracks top level fields (msgId, anonId, event) as mapped properties', function() {
12071215
adobeAnalytics.options.props = {
12081216
anonymousId: 'prop1',
1209-
messageId: 'prop2'
1217+
messageId: 'prop2',
1218+
event: 'prop3'
12101219
};
12111220
analytics.page('Drank Some Milk', {
12121221
type: '2%',
@@ -1216,6 +1225,7 @@ describe('Adobe Analytics', function() {
12161225
analytics.equal(window.s.pageName, 'Drank Some Milk');
12171226
analytics.assert(window.s.prop1);
12181227
analytics.assert(window.s.prop2);
1228+
analytics.assert(window.s.prop3);
12191229
analytics.called(window.s.t);
12201230
});
12211231

@@ -1241,14 +1251,16 @@ describe('Adobe Analytics', function() {
12411251
analytics.called(window.s.t);
12421252
});
12431253

1244-
it('should send top level fields (msgId & anonId) as context properties', function() {
1254+
it('should send top level fields (msgId, anonId, event) as context properties', function() {
12451255
adobeAnalytics.options.contextValues = {
12461256
anonymousId: 'anonymousId',
1247-
messageId: 'messageId'
1257+
messageId: 'messageId',
1258+
event: 'eventContextData'
12481259
};
12491260
analytics.page('Page1', {});
12501261
analytics.assert(window.s.contextData.anonymousId);
12511262
analytics.assert(window.s.contextData.messageId);
1263+
analytics.assert(window.s.contextData.eventContextData);
12521264
analytics.called(window.s.t);
12531265
});
12541266

0 commit comments

Comments
 (0)