cleanup tests

ISSUE: CLDSRVCLT-2

Author: SylvainSenechal

tests/testApis.test.ts

@@ -50,7 +50,6 @@ describe('CloudServer API Tests', () => {
     });
 
     it('should test GetSingleObject', async () => {
-        // S3VAULT=mem S3METADATA=scality S3DATA=mem
         const getInput: GetObjectInput = {
             Bucket: testConfig.bucketName,
             Key: testConfig.objectKey,
@@ -76,7 +75,6 @@ describe('CloudServer API Tests', () => {
     });
 
     it('should test BatchDelete', async () => {
-        // S3VAULT=mem S3METADATA=scality S3DATA=mem
         const locations: BatchDeleteLocation[] = [
             {
                 dataStoreName: "mem", 

tests/testErrorHandling.test.ts

@@ -16,8 +16,6 @@ describe('CloudServer test error handling', () => {
     });
 
     it('should test xml parsing', async () => {
-        // Run CloudServer with : S3VAULT=mem S3METADATA=mem S3DATA=mem REMOTE_MANAGEMENT_DISABLE=true yarn start
-        // Needs to tamper with Cloudserver response manually to return an html error..
         try {
             const getInput: GetObjectInput = {
                 Bucket: testConfig.bucketName,
@@ -35,6 +33,7 @@ describe('CloudServer test error handling', () => {
 
     it.skip('should test html parsing', async () => {
         // Run CloudServer with : S3VAULT=mem S3METADATA=mem S3DATA=mem REMOTE_MANAGEMENT_DISABLE=true yarn start
+        // Needs to tamper with Cloudserver response manually to return an html error
         try {
             const deleteInput: MultipleBackendDeleteObjectInput = {
                 Bucket: 'testConfig.bucketName',

tests/testIndexesApis.test.ts

@@ -18,7 +18,6 @@ describe('CloudServer Indexes API Tests', () => {
     });
 
     it('should test PutBucketIndexes', async () => {
-        // S3VAULT=mem S3METADATA=mongodb S3DATA=mem
         const indexData = JSON.stringify([
             {
                 name: "testIndex1",
@@ -38,7 +37,6 @@ describe('CloudServer Indexes API Tests', () => {
     });
 
     it('should test GetBucketIndexes', async () => {
-        // S3VAULT=mem S3METADATA=mongodb S3DATA=mem
         const getBucketIndexesInput: GetBucketIndexesInput = {
             Bucket: testConfig.bucketName,
         };

tests/testLifecycleApis.test.ts

@@ -20,7 +20,6 @@ describe('CloudServer Lifecycle API Tests', () => {
     });
 
     it('should test ListLifecycleCurrents', async () => {
-        // Run Cloudserver with : S3VAULT=mem S3METADATA=mongodb S3DATA=mem REMOTE_MANAGEMENT_DISABLE=true yarn start
         const listInput: ListLifecycleCurrentsInput = {
             Bucket: testConfig.bucketName,
             MaxKeys: 1,

tests/testMetadataApis.test.ts

@@ -18,7 +18,6 @@ describe('CloudServer Metadata API Tests', () => {
     });
 
     it('should test GetMetadata API', async () => {
-        // Run Cloudserver with : S3VAULT=mem S3METADATA=mongodb S3DATA=mem REMOTE_MANAGEMENT_DISABLE=true yarn start
         const getMetadataInput: GetMetadataInput = {
             Bucket: testConfig.bucketName,
             Key: testConfig.objectKey,
@@ -29,14 +28,14 @@ describe('CloudServer Metadata API Tests', () => {
     });
 
     it('should test PutMetadata API', async () => {
-        // S3VAULT=mem S3METADATA=scality S3DATA=mem
         const metadataObj = {
             "content-length": 1000,
             "content-type": "text/plain",
             "x-amz-meta-custom": "test-valuee",
             "last-modified": new Date().toISOString(),
             "etag": "\"d41d8cd98f00b204e9800998ecf8427e\"",
-            "x-amz-version-id": "null"
+            "x-amz-version-id": "null",
+            "replicationInfo": {}
         };
 
         const metadataString = JSON.stringify(metadataObj);
@@ -55,7 +54,6 @@ describe('CloudServer Metadata API Tests', () => {
 
 
     it('should test GetBucketMetadata API', async () => {
-        // S3VAULT=mem S3METADATA=scality S3DATA=mem
         const getBucketMetadataInput: GetBucketMetadataInput = {
             Bucket: testConfig.bucketName,
         };

tests/testMultipleBackendApis.test.ts

@@ -184,7 +184,7 @@ describe('CloudServer Multiple Backend API Tests', () => {
         }
     });
 
-    it('should test MultipleBackendMPU API', async () => {
+    it.skip('should test MultipleBackendMPU API', async () => {
         const initiateMPUInput: MultipleBackendInitiateMPUInput = {
             Bucket: testConfig.bucketName,
             Key: `${testConfig.objectKey}-mpu`,

tests/testRaftApis.test.ts

@@ -107,7 +107,7 @@ describe('CloudServer Raft API Tests', () => {
                 logRes.log.on('data', (record: any) => {
                     logStats.nbLogRecordsRead += 1;
                     if (record.entries) {
-                        record.entries.forEach((entry: any) => {
+                        record.entries.forEach((_entry: any) => {
                             logStats.nbLogEntriesRead += 1;
                         });
                     }

tests/testSetup.ts

@@ -1,4 +1,5 @@
 import https from 'https';
+import assert from 'assert';
 import { CloudserverClient, CloudserverClientConfig } from '../src/index';
 import { S3Client, PutObjectCommand, CreateBucketCommand, PutBucketVersioningCommand } from '@aws-sdk/client-s3';
 import { AwsCredentialIdentity, AwsCredentialIdentityProvider } from '@aws-sdk/types';
@@ -71,7 +72,7 @@ async function initBucketForTests() {
         });
         await s3client.send(putObjectCommand);
     } catch (error: any) {
-        console.log('S3 operation failed:', error);
+        assert.fail(`Failed to initialize bucket for tests: ${error}`);
     }
 }