Backport to branch(3.17) : Fix to increase the maximum allowed string length with Object Storage

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix to increase the maximum allowed string length with Object Storage #3248
• Backported commit: f1858f6

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a critical fix aimed at enhancing the handling of large data within Object Storage. It addresses potential limitations by significantly increasing the maximum allowed string length for internal serialization processes and, more importantly, implements a robust validation mechanism for BLOB column values. This validation proactively checks the size of BLOBs before storage, ensuring they do not exceed a calculated limit and preventing data integrity issues, thereby improving the system's resilience when dealing with substantial binary data.

Highlights

• Increased Maximum String Length: The maximum allowed string length for JSON serialization within Object Storage has been set to Integer.MAX_VALUE by configuring the ObjectMapper's StreamReadConstraints.
• BLOB Column Size Validation: A new validation check has been introduced for BLOB columns in Object Storage operations. It ensures that the size of a BLOB value, considering Base64 encoding, does not exceed a calculated maximum derived from the MAX_STRING_LENGTH_ALLOWED.
• New Error Type: A specific error, OBJECT_STORAGE_BLOB_EXCEEDS_MAX_LENGTH_ALLOWED, has been added to CoreError to be thrown when a BLOB column value exceeds its permitted size.
• Unit Tests for BLOB Size Check: New unit tests have been added to ObjectStorageOperationCheckerTest to verify that BLOB columns within the allowed size pass validation, and those exceeding it correctly trigger an IllegalArgumentException.
• Integration Test Refactoring: Utility methods prepareGet and preparePuts in DistributedStorageIntegrationTestBase have been changed from private to protected to allow for greater reusability in subclasses.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request increases the maximum allowed string length for Object Storage, which enables storing larger BLOB values. The change involves updating the Jackson ObjectMapper's stream read constraints and adding a pre-emptive check for BLOB column sizes in ObjectStorageOperationChecker. The implementation is sound and includes relevant unit tests. I have one suggestion to improve the clarity of an error message to make it more helpful for developers.