Fix pickling positions problem

Make parameter definitions in DefDef have the same span as the symbols
they define. Previously, this position was not set, which means it would
be set pretty much in an ad-hoc way based on the positions that were set
in the definitions environment. For some reason I cannot quite reconstruct,
the changes to opaque caused pos/exports.scala to fail pickling tests
because an extension parameter symbol symbol a different position after
pickling.

Author: odersky

compiler/src/dotty/tools/dotc/ast/tpd.scala

@@ -206,8 +206,12 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo {
   def DefDef(sym: TermSymbol, tparams: List[TypeSymbol], vparamss: List[List[TermSymbol]],
              resultType: Type, rhs: Tree)(implicit ctx: Context): DefDef =
     ta.assignType(
-      untpd.DefDef(sym.name, tparams map TypeDef, vparamss.nestedMap(ValDef(_)),
-                   TypeTree(resultType), rhs),
+      untpd.DefDef(
+        sym.name,
+        tparams.map(tparam => TypeDef(tparam).withSpan(tparam.span)),
+        vparamss.nestedMap(vparam => ValDef(vparam).withSpan(vparam.span)),
+        TypeTree(resultType),
+        rhs),
       sym)
 
   def DefDef(sym: TermSymbol, rhs: Tree = EmptyTree)(implicit ctx: Context): DefDef =