Fix compilation units not beeing loaded if already loaded symbol

Not all classes where loaded depending on the order of the compilation

Author: nicolasstucki

compiler/src/dotty/tools/dotc/fromtasty/ReadTastyTreesFromClasses.scala

@@ -66,11 +66,10 @@ class ReadTastyTreesFromClasses extends FrontEnd {
           clsd.infoOrCompleter match {
             case info: ClassfileLoader =>
               info.load(clsd) // sets cls.treeOrProvider and cls.moduleClass.treeProvider as a side-effect
-              def moduleClass = clsd.owner.info.member(className.moduleClassName).symbol
-              compilationUnit(clsd.classSymbol).orElse(compilationUnit(moduleClass))
             case _ =>
-              alreadyLoaded()
           }
+          def moduleClass = clsd.owner.info.member(className.moduleClassName).symbol
+          compilationUnit(clsd.classSymbol).orElse(compilationUnit(moduleClass))
         case _ =>
           cannotUnpickle(s"no class file was found")
       }

compiler/test/dotty/tools/dotc/FromTastyTests.scala

@@ -29,9 +29,7 @@ class FromTastyTests extends ParallelTesting {
     val (step1, step2, step3) = compileTastyInDir("tests/pos", defaultOptions,
       blacklist = Set(
         "macro-deprecate-dont-touch-backquotedidents.scala",
-
-        // Compiles wrong class
-        "simpleClass.scala",
+        "t247.scala",
 
         // Wrong number of arguments
         "i3130b.scala",
@@ -84,6 +82,7 @@ class FromTastyTests extends ParallelTesting {
        blacklist = Set(
 
          "t7223.scala",
+         "t5428.scala",
 
          // Missing position
          "Course-2002-13.scala",

tests/pos/simpleClass-2.decompiled

@@ -0,0 +1,14 @@
+================================================================================
+out/posTestFromTasty/pos2/simpleClass-2/foo/B.class
+--------------------------------------------------------------------------------
+package foo {
+  class B() extends Object() {}
+}
+--------------------------------------------------------------------------------
+================================================================================
+out/posTestFromTasty/pos2/simpleClass-2/foo/A.class
+--------------------------------------------------------------------------------
+package foo {
+  class A() extends foo.B() {}
+}
+--------------------------------------------------------------------------------

tests/pos/simpleClass-2.scala

@@ -0,0 +1,6 @@
+package foo
+
+class B
+
+class A extends B
+

tests/pos/simpleClass.decompiled

@@ -1,5 +1,12 @@
 ================================================================================
-out/posTestFromTasty/pos/simpleClass/foo/A.class
+out/posTestFromTasty/pos2/simpleClass/foo/B.class
+--------------------------------------------------------------------------------
+package foo {
+  class B() extends foo.A() {}
+}
+--------------------------------------------------------------------------------
+================================================================================
+out/posTestFromTasty/pos2/simpleClass/foo/A.class
 --------------------------------------------------------------------------------
 package foo {
   class A() extends Object() {}