Reorder pattern match based on frequency

NamedPartsAccumulator.apply total number of matches when compiling
the dotty bootstrapped compiler

(TypeRef,255627)
(ThisType,128253)
(NoPrefix,67972)
(TermRef,33240)
(AppliedType,22874)
(default,13428)
(TypeBounds,5013)
(ParamRef,3931)
(ConstantType,1893)

Author: nicolasstucki

compiler/src/dotty/tools/dotc/core/Types.scala

@@ -4315,19 +4315,23 @@ object Types {
       else {
         seen += tp
         tp match {
-          case tp: TermRef =>
-            apply(foldOver(maybeAdd(x, tp), tp), tp.underlying)
           case tp: TypeRef =>
             foldOver(maybeAdd(x, tp), tp)
+          case tp: ThisType =>
+            apply(x, tp.tref)
+          case NoPrefix =>
+            foldOver(x, tp)
+          case tp: TermRef =>
+            apply(foldOver(maybeAdd(x, tp), tp), tp.underlying)
+          case tp: AppliedType =>
+            foldOver(x, tp)
           case TypeBounds(lo, hi) =>
             if (!excludeLowerBounds) apply(x, lo)
             apply(x, hi)
-          case tp: ThisType =>
-            apply(x, tp.tref)
-          case tp: ConstantType =>
-            apply(x, tp.underlying)
           case tp: ParamRef =>
             apply(x, tp.underlying)
+          case tp: ConstantType =>
+            apply(x, tp.underlying)
           case _ =>
             foldOver(x, tp)
         }