Skip to content

Commit 3fd441c

Browse files
nephrosnephros
authored andcommitted
Hotcache: Don't be a template class
- Try a Q_OBJECT macro for a template class... - Don't be a template class - Become Object-based, add contructor - Implement a constructor
1 parent a1826a4 commit 3fd441c

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

src/bin/patchmanager-daemon/patchmanagerobject.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3020,6 +3020,13 @@ void PatchManagerObject::setupFilter()
30203020
*
30213021
* \sa m_filter
30223022
*/
3023+
3024+
PatchManagerFilter::PatchManagerFilter(QObject *parent, int maxCost )
3025+
: QObject(parent)
3026+
, QCache(maxCost)
3027+
{
3028+
}
3029+
30233030
void PatchManagerFilter::setup()
30243031
{
30253032
static const char *etcList[] = {

src/bin/patchmanager-daemon/patchmanagerobject.h

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,18 +75,17 @@ class QNetworkAccessManager;
7575
class PatchManagerAdaptor;
7676
class QLocalServer;
7777

78-
template <typename Key, typename T>
79-
class PatchManagerFilter : public QCache<Key, T>
78+
class PatchManagerFilter : public QObject, public QCache<QString, QObject>
8079
{
81-
//Q_OBJECT
82-
//Q_PROPERTY(bool active READ active WRITE setActive NOTIFY activeChanged)
80+
Q_OBJECT
81+
Q_PROPERTY(bool active READ active WRITE setActive NOTIFY activeChanged)
8382
public:
84-
//PatchManagerFilter(quint maxCost = 100) : QCache(maxCost)
83+
PatchManagerFilter(QObject *parent = nullptr, int maxCost = 100);
8584
//~PatchManagerFilter();
8685

8786
void setup();
8887
// override QCache::contains()
89-
bool contains(const Key &key) const
88+
bool contains(const QString &key) const
9089
{
9190
if (m_active) {
9291
return false;
@@ -300,7 +299,7 @@ private slots:
300299
QTimer *m_sessionBusConnector = nullptr;
301300
QDBusConnection m_sbus;
302301

303-
PatchManagerFilter<QString, QObject> m_filter;
302+
PatchManagerFilter m_filter;
304303
void setupFilter();
305304
};
306305

0 commit comments

Comments
 (0)