frontend/projects: fix icon of starred or recent directories #8664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldschilly
added
the
PR-TODO-cocalc2
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where directories in starred or recent file lists were displaying with a question mark icon (?) instead of the appropriate folder icon. The fix adds directory detection logic based on the trailing slash convention used throughout the codebase.
Key Changes
- Added directory detection by checking if filenames end with
/ - Directories now display with
"folder-open"icon instead of falling through to the unknown file type icon
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
haraldschilly
added
PR-positive review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a trivial fix: directories had a (?) icon, but should have their folder icon.