fix #7797 -- latex: clicking to download the pdf when the pdf doesn't exist silently fails

Author: williamstein

src/packages/frontend/frame-editors/latex-editor/actions.ts

@@ -1494,9 +1494,18 @@ export class Actions extends BaseActions<LatexEditorState> {
 
   download_pdf(): void {
     const path: string = pdf_path(this.path);
+
+    // we use auto false and true, since the pdf may not exist, and we don't want
+    // a **silent failure**.  With auto:false, the pdf appears in a new tab
+    // and user has to click again to actually get it on their computer, but
+    // auto:true makes it so it downloads automatically to avoid that click.
+    // If there is an error, that is clear too.
+    this.redux
+      .getProjectActions(this.project_id)
+      .download_file({ path, log: true, auto: false });
     this.redux
       .getProjectActions(this.project_id)
-      .download_file({ path: path, log: true });
+      .download_file({ path, log: false, auto: true });
   }
 
   print(id: string): void {