Merge pull request #8482 from sagemathinc/disable-pwa

frontend: disable PWA install app

Author: williamstein

src/packages/hub/manifest.ts

@@ -10,6 +10,10 @@ import { join } from "path";
 import { SiteSettingsKeys } from "@cocalc/util/db-schema/site-defaults";
 import base_path from "@cocalc/backend/base-path";
 
+// Control PWA installability -- https://github.com/sagemathinc/cocalc/issues/8474
+// Keeps theme colors and styling but prevents Chrome's "Install app" prompt
+const ENABLE_PWA_INSTALL = false;
+
 interface Custom {
   configuration: Record<SiteSettingsKeys, string>;
 }
@@ -23,12 +27,11 @@ export function send(res: Response, custom: Custom) {
 
   const base_app = join(base_path, "app");
 
-  const manifest = {
+  const manifest: any = {
     name: config.site_name,
     short_name: config.site_name,
     start_url: `${base_app}?utm_medium=manifest`,
     scope: base_path,
-    display: "minimal-ui",
     background_color: "#fbb635",
     theme_color: "#4474c0",
     description: config.site_description,
@@ -43,5 +46,10 @@ export function send(res: Response, custom: Custom) {
     ],
   };
 
+  // Without that display property, browsers won't show the "Install app" prompt
+  if (ENABLE_PWA_INSTALL) {
+    manifest.display = "minimal-ui";
+  }
+
   res.send(JSON.stringify(manifest, null, 2));
 }

src/packages/static/src/load.tsx

@@ -17,7 +17,6 @@ const loadContainer = document.getElementById("cocalc-load-container");
 if (loadContainer) {
   createRoot(loadContainer).render(
     <>
-      <Manifest />
       <PreflightCheck />
       <StartupBanner />
     </>
@@ -32,6 +31,7 @@ const scriptsContainer = document.getElementById("cocalc-scripts-container");
 if (scriptsContainer != null) {
   createRoot(scriptsContainer).render(
     <span>
+      <Manifest />
       <Meta />
       <Favicons />
     </span>