Merge remote-tracking branch 'origin/master' into rm-tracking-cookie

Author: haraldschilly

.github/workflows/make-and-test.yml

@@ -1,4 +1,4 @@
-name: Make all packages and run their tests
+name: Test
 
 # newer commits in the same PR abort running ones for the same workflow
 concurrency:
@@ -43,7 +43,7 @@ jobs:
       - name: Check doc links
         run: cd src/scripts && python3 check_doc_urls.py || sleep 5 || python3 check_doc_urls.py
 
-  build:
+  test:
     runs-on: ubuntu-latest
 
     services:
@@ -94,7 +94,7 @@ jobs:
       - name: Download and install Valkey
         run: |
           VALKEY_VERSION=8.1.2
-          curl -LO https://download.valkey.io/releases/valkey-${VALKEY_VERSION}-jammy-x86_64.tar.gz
+          curl -LOq https://download.valkey.io/releases/valkey-${VALKEY_VERSION}-jammy-x86_64.tar.gz
           tar -xzf valkey-${VALKEY_VERSION}-jammy-x86_64.tar.gz
           sudo cp valkey-${VALKEY_VERSION}-jammy-x86_64/bin/valkey-server /usr/local/bin/
 
@@ -106,6 +106,52 @@ jobs:
           pip install ipykernel
           python -m ipykernel install --prefix=./jupyter-local --name python3-local --display-name "Python 3 (Local)"
 
-      - run: cd src && npm install -g pnpm
-      - run: cd src && pnpm run make
-      - run: source venv/bin/activate && cd src && pnpm run test-github-ci
+
+      - name: install pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10
+          run_install: false
+
+      - name: build
+        run: cd src && pnpm run make
+
+      # This runs all the tests with text output and jest-junit reporters to generate junit.xml reports
+      # That test-github-ci target runs workspaces.py for testing, which in turn runs the depchecks
+      - name: test
+        run: source venv/bin/activate && cd src && pnpm run test-github-ci --report
+
+      - name: upload test results
+        uses: actions/upload-artifact@v4  # upload test results
+        if: ${{ !cancelled() }}           # run this step even if previous step failed
+        with:
+          name: "test-results-node-${{ matrix.node-version }}-pg-${{ matrix.pg-version }}"
+          path: 'src/packages/*/junit.xml'
+
+  report:
+    runs-on: ubuntu-latest
+
+    needs: [test]
+
+    if: ${{ !cancelled() }}
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Download all test artifacts
+        uses: actions/download-artifact@v4
+        with:
+          pattern: "test-results-*"
+          merge-multiple: true
+          path: test-results/
+
+      - name: Test Report
+        uses: dorny/test-reporter@v2
+        with:
+          name: CoCalc Jest Tests
+          path: 'test-results/**/junit.xml'
+          reporter: jest-junit
+          use-actions-summary: 'true'
+          fail-on-error: false
+

.gitignore

@@ -159,3 +159,8 @@ src/packages/frontend/i18n/trans/*.compiled.json
 **/*.db
 **/project-env.sh
 **/*.bash_history
+
+src/.claude/settings.local.json
+
+# test reports by jest-junit
+junit.xml

src/.claude/settings.json

@@ -0,0 +1,24 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(find:*)",
+      "Bash(gh pr view:*)",
+      "Bash(gh:*)",
+      "Bash(git add:*)",
+      "Bash(git commit:*)",
+      "Bash(grep:*)",
+      "Bash(node:*)",
+      "Bash(npm show:*)",
+      "Bash(npx tsc:*)",
+      "Bash(pnpm build:*)",
+      "Bash(pnpm ts-build:*)",
+      "Bash(pnpm tsc:*)",
+      "Bash(prettier -w:*)",
+      "WebFetch(domain:cocalc.com)",
+      "WebFetch(domain:doc.cocalc.com)",
+      "WebFetch(domain:docs.anthropic.com)",
+      "WebFetch(domain:github.com)"
+    ],
+    "deny": []
+  }
+}

src/CLAUDE.md

@@ -1,6 +1,6 @@
-# CLAUDE.md
+# CLAUDE.md and GEMINI.md
 
-This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+This file provides guidance to Claude Code (claude.ai/code) and also Gemini CLI (https://github.com/google-gemini/gemini-cli) when working with code in this repository.
 
 # CoCalc Source Repository
 
@@ -43,7 +43,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ### Development
 
-- After code changes, run `pretter -w [filename]` to ensure consistent styling
+- **IMPORTANT**: Always run `prettier -w [filename]` immediately after editing any .ts, .tsx, .md, or .json file to ensure consistent styling
 - After TypeScript or `*.tsx` changes, run `pnpm build` in the relevant package directory
 
 ## Architecture Overview
@@ -87,6 +87,7 @@ CoCalc is organized as a monorepo with key packages:
 - **Database Queries**: Structured query system with typed interfaces
 - **Event Emitters**: Inter-service communication within backend
 - **REST-like APIs**: Some HTTP endpoints for specific operations
+- **API Schema**: API endpoints in `packages/next/pages/api/v2/` use Zod schemas in `packages/next/lib/api/schema/` for validation. These schemas must be kept in harmony with the TypeScript types sent from frontend applications using `apiPost` (in `packages/next/lib/api/post.ts`) or `api` (in `packages/frontend/client/api.ts`). When adding new fields to API requests, both the frontend types and the API schema validation must be updated.
 
 ### Key Technologies
 

src/GEMINI.md

@@ -0,0 +1 @@
+CLAUDE.md

src/packages/backend/conat/persist.ts

@@ -14,13 +14,16 @@ import { initContext } from "@cocalc/conat/persist/context";
 import { compress, decompress } from "zstd-napi";
 import { syncFiles } from "@cocalc/backend/data";
 import ensureContainingDirectoryExists from "@cocalc/backend/misc/ensure-containing-directory-exists";
+import { statSync, copyFileSync } from "node:fs";
 
 initContext({
   betterSqlite3,
   compress,
   decompress,
   syncFiles,
   ensureContainingDirectoryExists,
+  statSync,
+  copyFileSync,
 });
 
 export { pstream } from "@cocalc/conat/persist/storage";