fix #7683 -- New Signups No Longer Added from CoCalc to Salesloft

Author: williamstein

src/packages/server/salesloft/init.ts

@@ -25,9 +25,17 @@ export default async function init() {
     try {
       running = true;
       log.debug("Doing a salesloft MONEY update...");
-      await updateMoney("1 day");
+      try {
+        await updateMoney("1 day");
+      } catch (err) {
+        log.debug("WARNING -- issue doing updateMoney", err);
+      }
       log.debug("Doing a salesloft sync update...");
-      await update();
+      try {
+        await update();
+      } catch (err) {
+        log.debug("WARNING -- issue doing update", err);
+      }
     } catch (err) {
       log.debug("WARNING: Error doing salesloft update", err);
     } finally {

src/packages/server/salesloft/money.ts

@@ -59,7 +59,16 @@ export async function updateMoney(cutoff: string = "2 days") {
     }
     const data = await getMoneyData(account_id);
     log.debug("updateMoney: ", { salesloft_id: id, account_id, data });
-    await update(id, { custom_fields: data });
+    try {
+      await update(id, { custom_fields: data });
+    } catch (err) {
+      // this can happen, e.g., if the id for the person is no longer in salesloft for some reason
+      // or just invalid.  This is the case with my wstein@sagemath.com account, which caused
+      //   https://github.com/sagemathinc/cocalc/issues/7683
+      // Better is to just make this a warning and skip those accounts -- salesloft doesn't need
+      // perfect info about all users.
+      log.debug("WARNING ", err);
+    }
   }
 }
 

src/packages/server/salesloft/sync.ts

@@ -56,7 +56,7 @@ const log = logger.debug.bind(logger);
 
 export async function sync(
   account_ids: string[],
-  delayMs: number = 1000, // wait this long after handling each account_id
+  delayMs: number = 250, // wait this long after handling each account_id
   maxDelayMs: number = 1000 * 60 * 15, // exponential backoff up to this long.
 ): Promise<{
   update: number;