be a little more generous with saving compute server images before deprovisioning

Author: williamstein

src/packages/server/compute/maintenance/purchases/low-balance.ts

@@ -12,7 +12,7 @@ import getMinBalance from "@cocalc/server/purchases/get-min-balance";
 import adminAlert from "@cocalc/server/messages/admin-alert";
 
 // turn VM off if you don't have at least this much left.
-const COST_THRESH_DOLLARS = 2;
+const COST_THRESH_DOLLARS = 1;
 
 // If can't buy -- even if you increase all quotas and balance by
 // this amount -- then delete.  This is to avoid bad situations, e.g.,
@@ -27,7 +27,7 @@ const COST_THRESH_DOLLARS = 2;
 // NOTE: we do not automatically delete for a user with a negative balance
 // until it's way below (DELETE_THRESH_MARGIN_NEGATIVE_BALANCE) their negative,
 // as that indicates some trust.
-const DELETE_THRESH_MARGIN_DEFAULT = 0;
+const DELETE_THRESH_MARGIN_DEFAULT = 2;
 const DELETE_THRESH_MARGIN_NEGATIVE_BALANCE = 200;
 
 const logger = getLogger("server:compute:maintenance:purchase:low-balance");

src/packages/server/compute/maintenance/purchases/manage-purchases.test.ts

@@ -267,7 +267,7 @@ describe("confirm managing of purchases works", () => {
   // rule 6
   it("make time long so that balance is exceeded (but not by too much), and see that server gets stopped due to too low balance, and an email is sent to the user", async () => {
     resetTestMessages();
-    await setPurchaseStart(new Date(Date.now() - 1000 * 60 * 60 * 24 * 10));
+    await setPurchaseStart(new Date(Date.now() - 1000 * 60 * 60 * 24 * 7));
     const pool = getPool();
     await pool.query(
       "UPDATE compute_servers SET state='running', update_purchase=TRUE WHERE id=$1",