Skip to content

Commit 34aff49

Browse files
authored
Allow inlining of fns where the implementation is compile-time selected for x86 and armv 7 (#117)
1 parent 9f79ba2 commit 34aff49

File tree

8 files changed

+8
-12
lines changed

8 files changed

+8
-12
lines changed
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
simdutf8::implementation::armv7::validate_utf8_basic
21
simdutf8::implementation::armv7::validate_utf8_basic_neon
3-
simdutf8::implementation::armv7::validate_utf8_compat
42
simdutf8::implementation::armv7::validate_utf8_compat_neon
53
simdutf8::implementation::helpers::get_compat_error
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
simdutf8::implementation::helpers::get_compat_error
2-
simdutf8::implementation::x86::validate_utf8_basic
32
simdutf8::implementation::x86::validate_utf8_basic_avx2
4-
simdutf8::implementation::x86::validate_utf8_compat
53
simdutf8::implementation::x86::validate_utf8_compat_avx2
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
simdutf8::implementation::helpers::get_compat_error
2-
simdutf8::implementation::x86::validate_utf8_basic
32
simdutf8::implementation::x86::validate_utf8_basic_avx512
4-
simdutf8::implementation::x86::validate_utf8_compat
53
simdutf8::implementation::x86::validate_utf8_compat_avx512
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
simdutf8::implementation::helpers::get_compat_error
2-
simdutf8::implementation::x86::validate_utf8_basic
32
simdutf8::implementation::x86::validate_utf8_basic_sse42
4-
simdutf8::implementation::x86::validate_utf8_compat
53
simdutf8::implementation::x86::validate_utf8_compat_sse42
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
simdutf8::implementation::helpers::get_compat_error
2-
simdutf8::implementation::x86::validate_utf8_basic
32
simdutf8::implementation::x86::validate_utf8_basic_avx2
4-
simdutf8::implementation::x86::validate_utf8_compat
53
simdutf8::implementation::x86::validate_utf8_compat_avx2
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
simdutf8::implementation::helpers::get_compat_error
2-
simdutf8::implementation::x86::validate_utf8_basic
32
simdutf8::implementation::x86::validate_utf8_basic_avx512
4-
simdutf8::implementation::x86::validate_utf8_compat
53
simdutf8::implementation::x86::validate_utf8_compat_avx512

src/implementation/armv7/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ pub(crate) unsafe fn validate_utf8_basic(
4646
// validate_utf8_basic() no-std: implementation selection by config
4747

4848
#[cfg(all(feature = "armv7_neon", target_feature = "neon"))]
49+
#[inline]
4950
pub(crate) unsafe fn validate_utf8_basic(
5051
input: &[u8],
5152
) -> core::result::Result<(), crate::basic::Utf8Error> {
@@ -112,6 +113,7 @@ pub(crate) unsafe fn validate_utf8_compat(
112113
// validate_utf8_basic() no-std: implementation selection by config
113114

114115
#[cfg(all(feature = "armv7_neon", target_feature = "neon"))]
116+
#[inline]
115117
pub(crate) unsafe fn validate_utf8_compat(
116118
input: &[u8],
117119
) -> core::result::Result<(), crate::compat::Utf8Error> {

src/implementation/x86/mod.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ pub(crate) unsafe fn validate_utf8_basic(
153153
target_feature = "avx512vbmi",
154154
target_feature = "avx512vbmi2"
155155
))]
156+
#[inline]
156157
pub(crate) unsafe fn validate_utf8_basic(
157158
input: &[u8],
158159
) -> core::result::Result<(), crate::basic::Utf8Error> {
@@ -187,6 +188,7 @@ unsafe fn validate_utf8_basic_avx512(
187188
),
188189
all(target_feature = "avx2", feature = "std", not(avx512_stable))
189190
))]
191+
#[inline]
190192
pub(crate) unsafe fn validate_utf8_basic(
191193
input: &[u8],
192194
) -> core::result::Result<(), crate::basic::Utf8Error> {
@@ -230,6 +232,7 @@ unsafe fn validate_utf8_basic_avx2(
230232
not(target_feature = "avx2"),
231233
target_feature = "sse4.2"
232234
))]
235+
#[inline]
233236
pub(crate) unsafe fn validate_utf8_basic(
234237
input: &[u8],
235238
) -> core::result::Result<(), crate::basic::Utf8Error> {
@@ -356,6 +359,7 @@ pub(crate) unsafe fn validate_utf8_compat(
356359
target_feature = "avx512vbmi",
357360
target_feature = "avx512vbmi2"
358361
))]
362+
#[inline]
359363
pub(crate) unsafe fn validate_utf8_compat(
360364
input: &[u8],
361365
) -> core::result::Result<(), crate::compat::Utf8Error> {
@@ -390,6 +394,7 @@ unsafe fn validate_utf8_compat_avx512(
390394
),
391395
all(target_feature = "avx2", feature = "std", not(avx512_stable))
392396
))]
397+
#[inline]
393398
pub(crate) unsafe fn validate_utf8_compat(
394399
input: &[u8],
395400
) -> core::result::Result<(), crate::compat::Utf8Error> {
@@ -433,6 +438,7 @@ unsafe fn validate_utf8_compat_avx2(
433438
not(target_feature = "avx2"),
434439
target_feature = "sse4.2"
435440
))]
441+
#[inline]
436442
pub(crate) unsafe fn validate_utf8_compat(
437443
input: &[u8],
438444
) -> core::result::Result<(), crate::compat::Utf8Error> {

0 commit comments

Comments
 (0)