Rust edition 2018 + formatting + clippy (#84)

* Rust edition 2018 + formatting (closes #83)

* fix imports in tests

* fixed future compiler error in tests

* clippy code quality improvements

* removed unused impl of non-public struct

Author: phip1611

Cargo.toml

@@ -5,6 +5,7 @@ authors = ["Philipp Oppermann <dev@phil-opp.com>", "Calvin Lee <cyrus296@gmail.c
 license = "MIT/Apache-2.0"
 description = "An experimental Multiboot 2 crate for ELF-64/32 kernels."
 repository = "https://github.com/rust-osdev/multiboot2-elf64"
+edition = "2018"
 
 [dependencies]
 bitflags = "1"

src/elf_sections.rs

@@ -1,5 +1,5 @@
-use header::Tag;
-use core::fmt::{Formatter, Debug};
+use crate::header::Tag;
+use core::fmt::{Debug, Formatter};
 
 /// This tag contains section header table from an ELF kernel.
 ///
@@ -114,7 +114,7 @@ impl Default for ElfSectionIter {
             remaining_sections: 0,
             entry_size: 0,
             string_section: core::ptr::null(),
-            offset: 0
+            offset: 0,
         }
     }
 }
@@ -318,7 +318,7 @@ impl ElfSectionInner for ElfSectionInner64 {
     }
 
     fn addralign(&self) -> u64 {
-        self.addralign.into()
+        self.addralign
     }
 }
 

src/framebuffer.rs

@@ -1,6 +1,6 @@
+use crate::header::Tag;
+use crate::Reader;
 use core::slice;
-use header::Tag;
-use Reader;
 
 /// The VBE Framebuffer information Tag.
 #[derive(Debug, PartialEq)]
@@ -78,7 +78,7 @@ pub struct FramebufferColor {
     pub blue: u8,
 }
 
-pub fn framebuffer_tag<'a>(tag: &'a Tag) -> FramebufferTag<'a> {
+pub fn framebuffer_tag(tag: &Tag) -> FramebufferTag {
     let mut reader = Reader::new(tag as *const Tag);
     reader.skip(8);
     let address = reader.read_u64();

src/header.rs

@@ -1,6 +1,5 @@
-use core::marker::PhantomData;
 use core::fmt::{Debug, Formatter};
-use core::cmp::Ordering;
+use core::marker::PhantomData;
 
 /// Magic number that a multiboot2-compliant boot loader will store in `eax` register
 /// right before handoff to the payload (the kernel). This value can be used to check,
@@ -63,21 +62,6 @@ impl PartialEq<TagType> for TagType {
     }
 }
 
-impl PartialOrd<u32> for TagType {
-    fn partial_cmp(&self, other: &u32) -> Option<Ordering> {
-        let num = *self as u32;
-        Some(
-            if num < *other {
-                Ordering::Less
-            } else if num == *other {
-                Ordering::Equal
-            } else {
-                Ordering::Greater
-            }
-        )
-    }
-}
-
 /// All tags that could passed via the Multiboot2 information structure to a payload/program/kernel.
 /// Better not confuse this with the Multiboot2 header tags. They are something different.
 #[derive(Clone, Copy)]
@@ -119,7 +103,10 @@ impl<'a> Iterator for TagIter<'a> {
 
     fn next(&mut self) -> Option<&'a Tag> {
         match unsafe { &*self.current } {
-            &Tag { typ: TagType::End, size: 8 } => None, // end tag
+            &Tag {
+                typ: TagType::End,
+                size: 8,
+            } => None, // end tag
             tag => {
                 // go to next tag
                 let mut tag_addr = self.current as usize;