fix dogfood

Author: ada4a

tests/ui/arc_with_non_send_sync.rs

@@ -1,6 +1,5 @@
 //@aux-build:proc_macros.rs
 #![warn(clippy::arc_with_non_send_sync)]
-#![allow(unused_variables)]
 
 #[macro_use]
 extern crate proc_macros;
@@ -35,7 +34,7 @@ fn main() {
     let _ = Arc::new(RefCell::new(42));
     //~^ arc_with_non_send_sync
 
-    let mutex = Mutex::new(1);
+    let mutex = &Mutex::new(1);
     let _ = Arc::new(mutex.lock().unwrap());
     //~^ arc_with_non_send_sync
 

tests/ui/arc_with_non_send_sync.stderr

@@ -1,5 +1,5 @@
 error: usage of an `Arc` that is not `Send` and `Sync`
-  --> tests/ui/arc_with_non_send_sync.rs:35:13
+  --> tests/ui/arc_with_non_send_sync.rs:34:13
    |
 LL |     let _ = Arc::new(RefCell::new(42));
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -11,7 +11,7 @@ LL |     let _ = Arc::new(RefCell::new(42));
    = help: to override `-D warnings` add `#[allow(clippy::arc_with_non_send_sync)]`
 
 error: usage of an `Arc` that is not `Send` and `Sync`
-  --> tests/ui/arc_with_non_send_sync.rs:39:13
+  --> tests/ui/arc_with_non_send_sync.rs:38:13
    |
 LL |     let _ = Arc::new(mutex.lock().unwrap());
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -21,7 +21,7 @@ LL |     let _ = Arc::new(mutex.lock().unwrap());
    = help: otherwise make `MutexGuard<'_, i32>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
 
 error: usage of an `Arc` that is not `Send` and `Sync`
-  --> tests/ui/arc_with_non_send_sync.rs:42:13
+  --> tests/ui/arc_with_non_send_sync.rs:41:13
    |
 LL |     let _ = Arc::new(&42 as *const i32);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^

tests/ui/await_holding_lock.rs

@@ -173,7 +173,7 @@ async fn baz() -> u32 {
     42
 }
 
-async fn no_await(x: std::sync::Mutex<u32>) {
+async fn no_await(x: &std::sync::Mutex<u32>) {
     let mut guard = x.lock().unwrap();
     *guard += 1;
 }
@@ -182,7 +182,7 @@ async fn no_await(x: std::sync::Mutex<u32>) {
 // something the needs to be fixed in rustc. There's already drop-tracking, but this is currently
 // disabled, see rust-lang/rust#93751. This case isn't picked up by drop-tracking though. If the
 // `*guard += 1` is removed it is picked up.
-async fn dropped_before_await(x: std::sync::Mutex<u32>) {
+async fn dropped_before_await(x: &std::sync::Mutex<u32>) {
     let mut guard = x.lock().unwrap();
     //~^ ERROR: this `MutexGuard` is held across an await point
     *guard += 1;

tests/ui/branches_sharing_code/false_positives.rs

@@ -1,6 +1,6 @@
 //@ check-pass
 
-#![allow(dead_code)]
+#![allow(clippy::mut_mutex_lock)]
 #![deny(clippy::if_same_then_else, clippy::branches_sharing_code)]
 
 use std::sync::Mutex;

tests/ui/entry.fixed

@@ -255,8 +255,7 @@ mod issue_16173 {
 
     async fn f() {}
 
-    async fn foo() {
-        let mu_map = Mutex::new(HashMap::new());
+    async fn foo(mu_map: &Mutex<HashMap<i32, i32>>) {
         if !mu_map.lock().unwrap().contains_key(&0) {
             f().await;
             mu_map.lock().unwrap().insert(0, 0);

tests/ui/entry.rs

@@ -261,8 +261,7 @@ mod issue_16173 {
 
     async fn f() {}
 
-    async fn foo() {
-        let mu_map = Mutex::new(HashMap::new());
+    async fn foo(mu_map: &Mutex<HashMap<i32, i32>>) {
         if !mu_map.lock().unwrap().contains_key(&0) {
             f().await;
             mu_map.lock().unwrap().insert(0, 0);

tests/ui/entry.stderr

@@ -247,7 +247,7 @@ LL +     }
    |
 
 error: usage of `contains_key` followed by `insert` on a `HashMap`
-  --> tests/ui/entry.rs:285:5
+  --> tests/ui/entry.rs:284:5
    |
 LL | /     if !m.contains_key(&k) {
 LL | |

tests/ui/if_let_mutex.rs

@@ -5,7 +5,7 @@
 //@[edition2024] edition:2024
 //@[edition2024] check-pass
 #![warn(clippy::if_let_mutex)]
-#![allow(clippy::redundant_pattern_matching)]
+#![allow(clippy::redundant_pattern_matching, clippy::mut_mutex_lock)]
 
 use std::ops::Deref;
 use std::sync::Mutex;

tests/ui/let_underscore_lock.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::let_underscore_lock)]
+#![allow(clippy::mut_mutex_lock)]
 
 extern crate parking_lot;
 

tests/ui/let_underscore_lock.stderr

@@ -1,5 +1,5 @@
 error: non-binding `let` on a synchronization lock
-  --> tests/ui/let_underscore_lock.rs:10:5
+  --> tests/ui/let_underscore_lock.rs:11:5
    |
 LL |     let _ = p_m.lock();
    |     ^^^^^^^^^^^^^^^^^^^
@@ -9,23 +9,23 @@ LL |     let _ = p_m.lock();
    = help: to override `-D warnings` add `#[allow(clippy::let_underscore_lock)]`
 
 error: non-binding `let` on a synchronization lock
-  --> tests/ui/let_underscore_lock.rs:14:5
+  --> tests/ui/let_underscore_lock.rs:15:5
    |
 LL |     let _ = p_m1.lock();
    |     ^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
 
 error: non-binding `let` on a synchronization lock
-  --> tests/ui/let_underscore_lock.rs:18:5
+  --> tests/ui/let_underscore_lock.rs:19:5
    |
 LL |     let _ = p_rw.read();
    |     ^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
 
 error: non-binding `let` on a synchronization lock
-  --> tests/ui/let_underscore_lock.rs:20:5
+  --> tests/ui/let_underscore_lock.rs:21:5
    |
 LL |     let _ = p_rw.write();
    |     ^^^^^^^^^^^^^^^^^^^^^