WIP: don't lint statics

Author: ada4a

clippy_lints/src/methods/mut_mutex_lock.rs

@@ -73,8 +73,22 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, recv: &'tcx Expr<'tcx>, name_s
             // that the field type is not a `&T`, and we'll do that in the next iteration of the
             // loop, during adjustment checking
             ExprKind::Field(base, _) => r = base,
-            // No more projections to check
-            _ => break,
+            // We arrived at the innermost receiver
+            _ => {
+                if let ExprKind::Path(ref p) = r.kind
+                    && cx
+                        .qpath_res(p, r.hir_id)
+                        .opt_def_id()
+                        .and_then(|id| cx.tcx.static_mutability(id))
+                        == Some(Mutability::Not)
+                {
+                    // The mutex is stored in a `static`, and we don't want to suggest making that
+                    // mutable
+                    return;
+                }
+                // No more projections to check
+                break;
+            },
         }
     }
 

tests/ui/mut_mutex_lock.fixed

@@ -37,6 +37,12 @@ fn mut_ref_ref_mutex_lock() {
     *guard += 1;
 }
 
+static MTX: Mutex<i32> = Mutex::new(0);
+
+fn dont_suggest_on_statics() {
+    MTX.lock().unwrap();
+}
+
 mod issue16253 {
     use std::sync::{Arc, Mutex};
 

tests/ui/mut_mutex_lock.rs

@@ -37,6 +37,12 @@ fn mut_ref_ref_mutex_lock() {
     *guard += 1;
 }
 
+static MTX: Mutex<i32> = Mutex::new(0);
+
+fn dont_suggest_on_statics() {
+    MTX.lock().unwrap();
+}
+
 mod issue16253 {
     use std::sync::{Arc, Mutex};
 

tests/ui/mut_mutex_lock.stderr

@@ -14,79 +14,79 @@ LL |     let mut value = mut_ref_mut_ref_mutex.lock().unwrap();
    |                                           ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:68:26
+  --> tests/ui/mut_mutex_lock.rs:74:26
    |
 LL |             refmutself.0.lock().unwrap();
    |                          ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:70:20
+  --> tests/ui/mut_mutex_lock.rs:76:20
    |
 LL |             self.0.lock().unwrap();
    |                    ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:80:26
+  --> tests/ui/mut_mutex_lock.rs:86:26
    |
 LL |             refmutself.0.lock().unwrap();
    |                          ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:82:20
+  --> tests/ui/mut_mutex_lock.rs:88:20
    |
 LL |             self.0.lock().unwrap();
    |                    ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:203:28
+  --> tests/ui/mut_mutex_lock.rs:209:28
    |
 LL |             refmutself.0.0.lock().unwrap();
    |                            ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:205:22
+  --> tests/ui/mut_mutex_lock.rs:211:22
    |
 LL |             self.0.0.lock().unwrap();
    |                      ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:216:28
+  --> tests/ui/mut_mutex_lock.rs:222:28
    |
 LL |             refmutself.0.0.lock().unwrap();
    |                            ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:218:22
+  --> tests/ui/mut_mutex_lock.rs:224:22
    |
 LL |             self.0.0.lock().unwrap();
    |                      ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:251:28
+  --> tests/ui/mut_mutex_lock.rs:257:28
    |
 LL |             refmutself.0.0.lock().unwrap();
    |                            ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:253:22
+  --> tests/ui/mut_mutex_lock.rs:259:22
    |
 LL |             self.0.0.lock().unwrap();
    |                      ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:264:28
+  --> tests/ui/mut_mutex_lock.rs:270:28
    |
 LL |             refmutself.0.0.lock().unwrap();
    |                            ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:266:22
+  --> tests/ui/mut_mutex_lock.rs:272:22
    |
 LL |             self.0.0.lock().unwrap();
    |                      ^^^^ help: change this to: `get_mut`
 
 error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
-  --> tests/ui/mut_mutex_lock.rs:274:20
+  --> tests/ui/mut_mutex_lock.rs:280:20
    |
 LL |         mutexes[0].lock().unwrap();
    |                    ^^^^ help: change this to: `get_mut`