Add QEMU CI support #378
Merged
Add QEMU CI support #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romancardenas
requested changes
Dec 5, 2025
Contributor
romancardenas
left a comment
romancardenas
left a comment
There was a problem hiding this comment.
Thanks! Check my comment
xtask/src/main.rs
Outdated
Comment on lines
112
to
114
| thread::sleep(Duration::from_secs(3)); | ||
| let _ = child.kill(); | ||
| let output = child.wait_with_output()?; |
Contributor
There was a problem hiding this comment.
I'd rather just wait child to finish by itself instead of waiting 3 second (which is an arbitrary time) and killing the process
Contributor
Author
There was a problem hiding this comment.
DONE! I have removed it
romancardenas
approved these changes
Dec 5, 2025
Contributor
romancardenas
left a comment
romancardenas
left a comment
There was a problem hiding this comment.
LGTM! Let's wait a few days in case someone wants to do a second review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival PR for #372
This PR tends to add QEMU CI support and resolve issue #311