Merge #193: Remove unused generic

apoelstra · apoelstra · commit 7e0343211cf2 · 2024-08-06T23:40:23.000Z
7bdabff Remove unused generic (Tobin C. Harding) Pull request description: Just patch 2, draft until #192 goes in. Turns out `clippy` does not warn for unused generics. Fix: #191 ACKs for top commit: apoelstra: ACK 7bdabff successfully ran local tests; note that this is technically a breaking change Tree-SHA512: 42fe88f886f053eaf6d68128cee9cb0f20a94afdd46dfca7bc2326726a9c2a6d010905ee97f1d2c0f13bcf620acfba1cb5463a48989c5e88f580def22ee9e5da
diff --git a/src/primitives/decode.rs b/src/primitives/decode.rs
@@ -442,7 +442,7 @@ impl<'s> CheckedHrpstring<'s> {
     ///
     /// Converts the ASCII bytes representing field elements to the respective field elements.
     #[inline]
-    pub fn fe32_iter<I: Iterator<Item = u8>>(&self) -> AsciiToFe32Iter {
+    pub fn fe32_iter(&self, _: u8) -> AsciiToFe32Iter {
         AsciiToFe32Iter { iter: self.ascii.iter().copied() }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ impl<'s> CheckedHrpstring<'s> {`
`442`	`442`	`///`
`443`	`443`	`/// Converts the ASCII bytes representing field elements to the respective field elements.`
`444`	`444`	`#[inline]`
`445`		`- pub fn fe32_iter<I: Iterator<Item = u8>>(&self) -> AsciiToFe32Iter {`
	`445`	`+ pub fn fe32_iter(&self, _: u8) -> AsciiToFe32Iter {`
`446`	`446`	`AsciiToFe32Iter { iter: self.ascii.iter().copied() }`
`447`	`447`	`}`
`448`	`448`