Changelog #172

Author: lnicola

generated_assists.adoc

@@ -811,7 +811,7 @@ fn main() {
 
 [discrete]
 === `extract_function`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_function.rs#L38[extract_function.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_function.rs#L39[extract_function.rs]
 
 Extracts selected statements and comments into new function.
 
@@ -1724,7 +1724,7 @@ fn bar() {
 
 [discrete]
 === `inline_local_variable`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/inline_local_variable.rs#L19[inline_local_variable.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/inline_local_variable.rs#L18[inline_local_variable.rs]
 
 Inlines a local variable.
 
@@ -2668,7 +2668,7 @@ fn compute() -> Option<i32> { None }
 
 [discrete]
 === `replace_match_with_if_let`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_if_let_with_match.rs#L185[replace_if_let_with_match.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_if_let_with_match.rs#L187[replace_if_let_with_match.rs]
 
 Replaces a binary `match` with a wildcard pattern and no guards with an `if let` expression.
 
@@ -2698,52 +2698,6 @@ fn handle(action: Action) {
 ```
 
 
-[discrete]
-=== `replace_or_else_with_or`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_or_with_or_else.rs#L89[replace_or_with_or_else.rs]
-
-Replace `unwrap_or_else` with `unwrap_or` and `ok_or_else` with `ok_or`.
-
-.Before
-```rust
-fn foo() {
-    let a = Some(1);
-    a.unwra┃p_or_else(|| 2);
-}
-```
-
-.After
-```rust
-fn foo() {
-    let a = Some(1);
-    a.unwrap_or(2);
-}
-```
-
-
-[discrete]
-=== `replace_or_with_or_else`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_or_with_or_else.rs#L12[replace_or_with_or_else.rs]
-
-Replace `unwrap_or` with `unwrap_or_else` and `ok_or` with `ok_or_else`.
-
-.Before
-```rust
-fn foo() {
-    let a = Some(1);
-    a.unwra┃p_or(2);
-}
-```
-
-.After
-```rust
-fn foo() {
-    let a = Some(1);
-    a.unwrap_or_else(|| 2);
-}
-```
-
-
 [discrete]
 === `replace_qualified_name_with_use`
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_qualified_name_with_use.rs#L13[replace_qualified_name_with_use.rs]
@@ -2831,6 +2785,52 @@ fn main() {
 ```
 
 
+[discrete]
+=== `replace_with_eager_method`
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_method_eager_lazy.rs#L89[replace_method_eager_lazy.rs]
+
+Replace `unwrap_or_else` with `unwrap_or` and `ok_or_else` with `ok_or`.
+
+.Before
+```rust
+fn foo() {
+    let a = Some(1);
+    a.unwra┃p_or_else(|| 2);
+}
+```
+
+.After
+```rust
+fn foo() {
+    let a = Some(1);
+    a.unwrap_or(2);
+}
+```
+
+
+[discrete]
+=== `replace_with_lazy_method`
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/replace_method_eager_lazy.rs#L9[replace_method_eager_lazy.rs]
+
+Replace `unwrap_or` with `unwrap_or_else` and `ok_or` with `ok_or_else`.
+
+.Before
+```rust
+fn foo() {
+    let a = Some(1);
+    a.unwra┃p_or(2);
+}
+```
+
+.After
+```rust
+fn foo() {
+    let a = Some(1);
+    a.unwrap_or_else(|| 2);
+}
+```
+
+
 [discrete]
 === `sort_items`
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/sort_items.rs#L12[sort_items.rs]

generated_config.adoc

@@ -71,6 +71,11 @@ cargo check --quiet --workspace --message-format=json --all-targets
 Use `RUSTC_WRAPPER=rust-analyzer` when running build scripts to
 avoid checking unnecessary things.
 --
+[[rust-analyzer.cargo.extraArgs]]rust-analyzer.cargo.extraArgs (default: `[]`)::
++
+--
+Extra arguments that are passed to every cargo invocation.
+--
 [[rust-analyzer.cargo.extraEnv]]rust-analyzer.cargo.extraEnv (default: `{}`)::
 +
 --

generated_diagnostic.adoc

@@ -64,7 +64,7 @@ let a = A { a: 10 };
 
 
 === missing-match-arm
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/missing_match_arms.rs#L5[missing_match_arms.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/missing_match_arms.rs#L3[missing_match_arms.rs]
 
 This diagnostic is triggered if `match` block is missing one or more match arms.
 
@@ -75,6 +75,12 @@ This diagnostic is triggered if `match` block is missing one or more match arms.
 This diagnostic is triggered if an operation marked as `unsafe` is used outside of an `unsafe` function or block.
 
 
+=== need-mut
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mutability_errors.rs#L7[mutability_errors.rs]
+
+This diagnostic is triggered on mutating an immutable variable.
+
+
 === no-such-field
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/no_such_field.rs#L11[no_such_field.rs]
 
@@ -174,3 +180,9 @@ but can also indicate project setup problems.
 If you are seeing a lot of "proc macro not expanded" warnings, you can add this option to the
 `rust-analyzer.diagnostics.disabled` list to prevent them from showing. Alternatively you can
 enable support for procedural macros (see `rust-analyzer.procMacro.attributes.enable`).
+
+
+=== unused-mut
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mutability_errors.rs#L39[mutability_errors.rs]
+
+This diagnostic is triggered when a mutable variable isn't actually mutated.

generated_features.adoc

@@ -967,6 +967,16 @@ Only workspace crates are included, no crates.io dependencies or sysroot crates.
 image::https://user-images.githubusercontent.com/48062697/113065588-068bdb80-91b1-11eb-9a78-0b4ef1e972fb.gif[]
 
 
+=== View Mir
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/view_mir.rs#L6[view_mir.rs]
+
+|===
+| Editor  | Action Name
+
+| VS Code | **rust-analyzer: View Mir**
+|===
+
+
 === Workspace Symbol
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-db/src/symbol_index.rs#L155[symbol_index.rs]
 

thisweek/_posts/2023-03-13-changelog-172.adoc

@@ -0,0 +1,42 @@
+= Changelog #172
+:sectanchors:
+:experimental:
+:page-layout: post
+
+Commit: commit:f1e51afa450ecf352c1f01fc5a5b6d10792e3779[] +
+Release: release:2023-03-13[] (`v0.3.1435`)
+
+== New Features
+
+* pr:14232[], pr:14316[] MIR episode 2, add `need-mut` and experimental `unused-mut` diagnostics:
++
+image::https://user-images.githubusercontent.com/308347/224622684-20570ef7-e5b8-4dfc-8bdb-5c8fc53fea84.png["Screenshot showing an error when reassigning a non-mut variable"]
+* pr:14313[] add fancy buttons to the VS Code status message:
++
+image::https://user-images.githubusercontent.com/3757771/224274817-a5a8cb0c-7bda-454d-9772-5f839f360b9a.png["Screenshot showing the status and Stop, Reload, Restart and Open logs options in a status bar menu"]
+* pr:14266[] make `replace_or_with_or_else` assists more generally applicable.
+* pr:14328[] allow passing extra `cargo` args when running build scripts.
+
+== Fixes
+
+* pr:14323[] (first contribution) fix source root de-duplication.
+* pr:14267[] mark unresolved field, unresolved method and expected function diagnostics as experimental.
+* pr:14297[] add `libcore` dependency to proc macros.
+* pr:14282[] load proc macros for `rustc_private` crates.
+* pr:14260[] tighten `replace_match_with_if_let` applicability range.
+* pr:14271[] don't trigger unresolved method/field diagnostics on types containing errors.
+* pr:14284[] highlight unresolved derives as such.
+* pr:14248[] show diagnostic for `}` followed by `else` in `let-else` statement.
+* pr:14283[] don't send error notifications for workspace failures if server status is supported.
+* pr:14286[] fix block defmap not looking into tail expressions for macro calls.
+* pr:14291[] fix handling of multiple definition bindings in `convert_match_to_let_else`.
+* pr:14299[] fix searching inside bodies of attributed items.
+* pr:14300[] watch both stdout and stderr in flycheck.
+* pr:14306[] fix block with no termination in or-patterns.
+
+== Internal Improvements
+
+* pr:14261[] reuse the resolver in `InferenceContext` instead of rebuilding it when needed.
+* pr:14302[] add missing queries to `per_query_memory_usage`.
+* pr:14311[] don't attempt to compute diagnostics in library crates.
+* pr:14326[] rename `match_expr` field of `hir::diagnostics::MissingMatchArms`.