Rails Component interface kwargs uniformity

[mvkampen]

Given the following class hierarchy:

Superform::Rails::Component < ApplicationComponent
Superform::Rails::Form < Superform::Rails::Component
Superform::Rails::Form::Components::BaseComponent < Superform::Rails::Component

Superform::Rails::Form::Components::BaseComponent deviated its interface for attributes from the Superform::Rails::Component.
Where as Component assigns all remaining plat kwargs as attributes, in Components::BaseComponent it required the keyword :attributes.

superform/lib/superform/rails.rb

Line 206 in 122ca32

def initialize(field, attributes: {})

Suggestion to keep components interface consistent across the board and change this in Components::BaseComponent:

class Components::BaseComponent
      def initialize(field, **attributes)
        @field = field
        @attributes = attributes
      end

class Superform::Rails::Field
        def input(**attributes)
          Components::InputComponent.new(self, **attributes)
        end

This still allows you to pass attributes explicitly, should you want to:

def initialize(field, attributes: {})

But allows us to use keywords as expected in other components.
To make attributes required or give them default values, yet open for additional html attributes:

def initialize(field, selected: false, value:, **attributes)
end

[mvkampen]

Forwarding arguments with ... not supported till ruby 2.7

[bradgessler]

I vastly prefer when components are initialized with attributes that match HTML attributes when non-HTML arguments can be passed in via positional arguments; this, this change makes sense.

I think that's fairly straightforward for most of these components since field is always passed into the component. Where things can get tricky is when HTML attributes might need to be applied to different parts of the component, such as a select > option hierarchy.