From ad331d287eec49b4a802e8de3122861c3c207164 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Sat, 22 Nov 2025 13:04:01 +0100 Subject: [PATCH 1/2] Remove continue-on-error for benchmarks in CI * Otherwise new failures do not get noticed. * Instead, just exclude the benchmarks known to fail. * Relates to 6d43a4cc1306984a1e4919e5fbf80bd0e7bd9ede. There has been a couple failures which were due to the harness assuming Ractor is defined, this CI job helps catch such issues. There is also CRuby-specific code in run_benchmarks.rb, so this tests it's properly guarded. --- .github/workflows/test.yml | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6645e9c5..1807eb41 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -43,7 +43,18 @@ jobs: strategy: fail-fast: false matrix: - ruby: [ruby, head, truffleruby] + include: + - { ruby: ruby } + - { ruby: head } + - { + ruby: truffleruby, + # knucleotide: needs fork + # lobsters: commonmarker fails to install + # railsbench: NoMethodError: undefined method `[]=' for class Fiber (NoMethodError) + # ruby-lsp: rbs_extension.so: undefined symbol: ruby_vm_at_exit + # shipit: cannot load such file -- pty + extra_args: "--excludes=knucleotide,lobsters,railsbench,ruby-lsp,shipit" + } if: ${{ github.event_name != 'schedule' || github.repository == 'ruby/ruby-bench' }} steps: - uses: actions/checkout@v3 @@ -53,12 +64,11 @@ jobs: ruby-version: ${{ matrix.ruby }} - name: Test run_benchmarks.rb - run: ./run_benchmarks.rb + run: ./run_benchmarks.rb ${{ matrix.extra_args }} env: WARMUP_ITRS: '1' MIN_BENCH_ITRS: '1' MIN_BENCH_TIME: '0' - continue-on-error: ${{ matrix.ruby == 'truffleruby' }} benchmark-ractor: runs-on: ubuntu-latest From 6016b63d3dae94dafdd7281160210ee2a00ab20a Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Thu, 15 Jan 2026 19:10:52 +0100 Subject: [PATCH 2/2] Make syntax consistent in test.yml Co-authored-by: Takashi Kokubun --- .github/workflows/test.yml | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1807eb41..05f3acfa 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -44,17 +44,15 @@ jobs: fail-fast: false matrix: include: - - { ruby: ruby } - - { ruby: head } - - { - ruby: truffleruby, - # knucleotide: needs fork - # lobsters: commonmarker fails to install - # railsbench: NoMethodError: undefined method `[]=' for class Fiber (NoMethodError) - # ruby-lsp: rbs_extension.so: undefined symbol: ruby_vm_at_exit - # shipit: cannot load such file -- pty - extra_args: "--excludes=knucleotide,lobsters,railsbench,ruby-lsp,shipit" - } + - ruby: ruby + - ruby: head + - ruby: truffleruby + # knucleotide: needs fork + # lobsters: commonmarker fails to install + # railsbench: NoMethodError: undefined method `[]=' for class Fiber (NoMethodError) + # ruby-lsp: rbs_extension.so: undefined symbol: ruby_vm_at_exit + # shipit: cannot load such file -- pty + extra_args: "--excludes=knucleotide,lobsters,railsbench,ruby-lsp,shipit" if: ${{ github.event_name != 'schedule' || github.repository == 'ruby/ruby-bench' }} steps: - uses: actions/checkout@v3