test/openssl/test_ssl: adjust certificate expiry date

rhenium · rhenium · commit 21d611f3f44b · 2021-12-25T02:52:03.000+09:00
test_connect_certificate_verify_failed_exception_message occasionally fails. Is it possible that OpenSSL sees a different clock from Ruby by more than 10 seconds? http://ci.rvm.jp/logfiles/brlog.trunk-random0.20211111-072828 Let's give more time after the certificate expiration date to see if this fixes the flakiness. We had similar occasional failures in test_x509store.rb before, which disappeared after ruby/ruby commit 7930a352a57c and ruby/openssl commit fb2fcbb. (cherry picked from commit ruby/ruby@cd51bf6)
diff --git a/test/openssl/test_ssl.rb b/test/openssl/test_ssl.rb
@@ -1000,8 +1000,9 @@ def test_connect_certificate_verify_failed_exception_message
     }
 
     ctx_proc = proc { |ctx|
+      now = Time.now
       ctx.cert = issue_cert(@svr, @svr_key, 30, [], @ca_cert, @ca_key,
-                            not_before: Time.now-100, not_after: Time.now-10)
+                            not_before: now - 7200, not_after: now - 3600)
     }
     start_server(ignore_listener_error: true, ctx_proc: ctx_proc) { |port|
       store = OpenSSL::X509::Store.new

Original file line number	Diff line number	Diff line change
`@@ -1000,8 +1000,9 @@ def test_connect_certificate_verify_failed_exception_message`
`1000`	`1000`	`}`
`1001`	`1001`
`1002`	`1002`	`ctx_proc = proc { \|ctx\|`
	`1003`	`+ now = Time.now`
`1003`	`1004`	`ctx.cert = issue_cert(@svr, @svr_key, 30, [], @ca_cert, @ca_key,`
`1004`		`- not_before: Time.now-100, not_after: Time.now-10)`
	`1005`	`+ not_before: now - 7200, not_after: now - 3600)`
`1005`	`1006`	`}`
`1006`	`1007`	`start_server(ignore_listener_error: true, ctx_proc: ctx_proc) { \|port\|`
`1007`	`1008`	`store = OpenSSL::X509::Store.new`