Refactored brittle thread pool tests.

Author: jdantonio

spec/concurrent/ruby_thread_pool_executor_spec.rb

@@ -22,6 +22,33 @@ module Concurrent
 
     it_should_behave_like :thread_pool_executor
 
+    context '#remaining_capacity' do
+
+      let!(:expected_max){ 100 }
+
+      subject do
+        RubyThreadPoolExecutor.new(
+          min_threads: 10,
+          max_threads: 20,
+          idletime: 60,
+          max_queue: expected_max,
+          overflow_policy: :discard
+        )
+      end
+
+      it 'returns :max_length when no tasks are enqueued' do
+        5.times{ subject.post{ nil } }
+        sleep(0.1)
+        subject.remaining_capacity.should eq expected_max
+      end
+
+      it 'returns the remaining capacity when tasks are enqueued' do
+        100.times{ subject.post{ sleep(0.5) } }
+        sleep(0.1)
+        subject.remaining_capacity.should < expected_max
+      end
+    end
+
     context '#overload_policy' do
 
       let!(:min_threads){ 1 }

spec/concurrent/thread_pool_executor_shared.rb

@@ -144,18 +144,6 @@
       subject.remaining_capacity.should eq expected_max
     end
 
-    it 'returns :max_length when no tasks are enqueued' do
-      5.times{ subject.post{ nil } }
-      sleep(0.1)
-      subject.remaining_capacity.should eq eq expected_max
-    end
-
-    it 'returns the remaining capacity when tasks are enqueued' do
-      pending('intermittently failing')
-      100.times{ subject.post{ sleep(0.5) } }
-      subject.remaining_capacity.should < expected_max
-    end
-
     it 'returns :max_length when stopped' do
       100.times{ subject.post{ sleep(0.5) } }
       sleep(0.1)