chore: some optimizations on *imports changed locking

Author: d-biehl

robotcode/language_server/robotframework/diagnostics/imports_manager.py

@@ -1085,7 +1085,7 @@ async def _get_libdoc(name: str, args: Tuple[Any, ...], working_dir: str, base_d
         return await entry.get_libdoc()
 
     @_logger.call
-    async def get_libdoc_from_model(
+    def get_libdoc_from_model(
         self,
         model: ast.AST,
         source: str,

robotcode/language_server/robotframework/diagnostics/namespace.py

@@ -635,30 +635,51 @@ async def imports_changed(self, sender: Any, uri: DocumentUri) -> None:  # NOSON
 
     @_logger.call
     async def libraries_changed(self, sender: Any, libraries: List[LibraryDoc]) -> None:
-        for p in libraries:
-            if any(e for e in self._libraries.values() if e.library_doc == p):
-                if self.document is not None:
-                    self.document.set_data(Namespace.DataEntry, None)
-                await self.invalidate()
-                break
+        invalidate = False
+
+        async with self._initialize_lock, self._library_doc_lock, self._analyze_lock:
+            for p in libraries:
+                if any(e for e in self._libraries.values() if e.library_doc == p):
+                    invalidate = True
+                    break
+
+        if invalidate:
+            if self.document is not None:
+                self.document.set_data(Namespace.DataEntry, None)
+
+            await self.invalidate()
 
     @_logger.call
     async def resources_changed(self, sender: Any, resources: List[LibraryDoc]) -> None:
-        for p in resources:
-            if any(e for e in self._resources.values() if e.library_doc.source == p.source):
-                if self.document is not None:
-                    self.document.set_data(Namespace.DataEntry, None)
-                await self.invalidate()
-                break
+        invalidate = False
+
+        async with self._initialize_lock, self._library_doc_lock, self._analyze_lock:
+            for p in resources:
+                if any(e for e in self._resources.values() if e.library_doc.source == p.source):
+                    invalidate = True
+                    break
+
+        if invalidate:
+            if self.document is not None:
+                self.document.set_data(Namespace.DataEntry, None)
+
+            await self.invalidate()
 
     @_logger.call
     async def variables_changed(self, sender: Any, variables: List[LibraryDoc]) -> None:
-        for p in variables:
-            if any(e for e in self._variables.values() if e.library_doc.source == p.source):
-                if self.document is not None:
-                    self.document.set_data(Namespace.DataEntry, None)
-                await self.invalidate()
-                break
+        invalidate = False
+
+        async with self._initialize_lock, self._library_doc_lock, self._analyze_lock:
+            for p in variables:
+                if any(e for e in self._variables.values() if e.library_doc.source == p.source):
+                    invalidate = True
+                    break
+
+        if invalidate:
+            if self.document is not None:
+                self.document.set_data(Namespace.DataEntry, None)
+
+            await self.invalidate()
 
     async def is_initialized(self) -> bool:
         async with self._initialize_lock:
@@ -753,7 +774,7 @@ async def get_imported_variables(self) -> OrderedDict[str, VariablesEntry]:
     async def get_library_doc(self) -> LibraryDoc:
         async with self._library_doc_lock:
             if self._library_doc is None:
-                self._library_doc = await self.imports_manager.get_libdoc_from_model(
+                self._library_doc = self.imports_manager.get_libdoc_from_model(
                     self.model,
                     self.source,
                     model_type="RESOURCE",

robotcode/utils/async_tools.py

@@ -465,7 +465,7 @@ def aaa(fut: asyncio.Future[Any]) -> None:
                     warnings.warn(f"Lock {self} takes to long {threading.current_thread()}\n, try to cancel...")
                     fut.cancel()
 
-                h = fut.get_loop().call_later(120, aaa, fut)
+                h = fut.get_loop().call_later(60, aaa, fut)
                 try:
                     await fut
                 finally: