fix(robotlangserver): Loading documents hardened

Invalid document don't break loading, initializing and analysing documents and discovering tests

Author: d-biehl

robotcode/language_server/robotframework/diagnostics/imports_manager.py

@@ -424,7 +424,11 @@ async def check_file_changed(self, changes: List[FileEvent]) -> Optional[FileCha
                     continue
 
                 path = uri.to_path()
-                if self._lib_doc.source and path.resolve().samefile(Path(self._lib_doc.source).resolve()):
+                if (
+                    self._lib_doc.source
+                    and path.exists()
+                    and path.resolve().samefile(Path(self._lib_doc.source).resolve())
+                ):
                     await self._invalidate()
 
                     return change.type

robotcode/language_server/robotframework/parts/robot_workspace.py

@@ -100,21 +100,27 @@ async def _load_workspace_documents(self, sender: Any) -> List[WorkspaceDocument
                 async with self.parent.window.progress(
                     "Load workspace", cancellable=True, current=0, max=len(files), start=False
                 ) as progress:
-                    for i, f in enumerate(files):
-                        await self.parent.documents.get_or_open_document(f, "robotframework")
-
-                        if config.analysis.progress_mode != AnalysisProgressMode.OFF:
-                            name = f.relative_to(folder.uri.to_path())
-
-                            progress.begin()
-                            progress.report(
-                                f"Load {str(name)}"
-                                if config.analysis.progress_mode == AnalysisProgressMode.DETAILED
-                                else None,
-                                current=i,
-                            )
-
-                    self.documents_loaded.set()
+                    try:
+                        for i, f in enumerate(files):
+                            try:
+                                await self.parent.documents.get_or_open_document(f, "robotframework")
+
+                                if config.analysis.progress_mode != AnalysisProgressMode.OFF:
+                                    name = f.relative_to(folder.uri.to_path())
+
+                                    progress.begin()
+                                    progress.report(
+                                        f"Load {str(name)}"
+                                        if config.analysis.progress_mode == AnalysisProgressMode.DETAILED
+                                        else None,
+                                        current=i,
+                                    )
+                            except (SystemExit, KeyboardInterrupt):
+                                raise
+                            except BaseException as e:
+                                self._logger.critical(f"Can't load document {f}: {e}")
+                    finally:
+                        self.documents_loaded.set()
 
                     for i, f in enumerate(files):
                         try:
@@ -154,7 +160,7 @@ async def _load_workspace_documents(self, sender: Any) -> List[WorkspaceDocument
                         except (SystemExit, KeyboardInterrupt, asyncio.CancelledError):
                             raise
                         except BaseException as e:
-                            self._logger.exception(e)
+                            self._logger.critical(f"Can't initialize document {f}: {e}")
 
             if canceled:
                 return []