Skip to content

Commit 8fc9827

Browse files
committed
Don't create to many threads per JSON request/notification
1 parent 689bf99 commit 8fc9827

File tree

15 files changed

+3
-35
lines changed

15 files changed

+3
-35
lines changed

robotcode/language_server/common/lsp_types.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1998,6 +1998,7 @@ class SemanticTokenTypes(Enum):
19981998
NUMBER = "number"
19991999
REGEXP = "regexp"
20002000
OPERATOR = "operator"
2001+
DECORATOR = "decorator"
20012002

20022003
def __repr__(self) -> str: # pragma: no cover
20032004
return super().__str__()

robotcode/language_server/robotframework/parts/codelens.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import ast
44
from typing import TYPE_CHECKING, Any, List, Optional, Set, Tuple, cast
55

6-
from ....utils.async_tools import create_sub_task, threaded
6+
from ....utils.async_tools import create_sub_task
77
from ....utils.logging import LoggingDescriptor
88
from ...common.decorators import language_id
99
from ...common.lsp_types import CodeLens, Command
@@ -38,7 +38,6 @@ async def codelens_refresh(self, sender: Any) -> None: # NOSONAR
3838
await self.parent.code_lens.refresh()
3939

4040
@language_id("robotframework")
41-
@threaded()
4241
async def collect(self, sender: Any, document: TextDocument) -> Optional[List[CodeLens]]:
4342

4443
from ..utils.async_ast import AsyncVisitor
@@ -91,7 +90,6 @@ async def visit_KeywordName(self, node: ast.AST) -> None: # noqa: N802
9190
return await Visitor.find_from(await self.parent.documents_cache.get_model(document), self)
9291

9392
@language_id("robotframework")
94-
@threaded()
9593
async def resolve(self, sender: Any, code_lens: CodeLens) -> Optional[CodeLens]:
9694
if code_lens.data is None:
9795
return code_lens

robotcode/language_server/robotframework/parts/completion.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
)
2424

2525
from ....utils.async_itertools import async_chain, async_chain_iterator, async_next
26-
from ....utils.async_tools import threaded
2726
from ....utils.logging import LoggingDescriptor
2827
from ...common.decorators import language_id, trigger_characters
2928
from ...common.lsp_types import (
@@ -103,7 +102,6 @@ async def get_section_style(self, document: TextDocument) -> str:
103102
)
104103
# @all_commit_characters(['\n'])
105104
@language_id("robotframework")
106-
@threaded()
107105
@_logger.call
108106
async def collect(
109107
self, sender: Any, document: TextDocument, position: Position, context: Optional[CompletionContext]
@@ -123,10 +121,8 @@ async def collect(
123121
)
124122

125123
@language_id("robotframework")
126-
@threaded()
127124
@_logger.call
128125
async def resolve(self, sender: Any, completion_item: CompletionItem) -> CompletionItem:
129-
130126
if completion_item.data is not None:
131127
document_uri = completion_item.data.get("document_uri", None)
132128
if document_uri is not None:

robotcode/language_server/robotframework/parts/document_highlight.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
from typing import TYPE_CHECKING, Any, List, Optional
44

5-
from ....utils.async_tools import threaded
65
from ....utils.logging import LoggingDescriptor
76
from ...common.decorators import language_id
87
from ...common.lsp_types import DocumentHighlight, DocumentHighlightKind, Position
@@ -24,7 +23,6 @@ def __init__(self, parent: RobotLanguageServerProtocol) -> None:
2423
parent.document_highlight.collect.add(self.collect)
2524

2625
@language_id("robotframework")
27-
@threaded()
2826
@_logger.call
2927
async def collect(
3028
self,

robotcode/language_server/robotframework/parts/document_symbols.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import itertools
55
from typing import TYPE_CHECKING, Any, List, Optional, Union, cast
66

7-
from ....utils.async_tools import threaded
87
from ....utils.logging import LoggingDescriptor
98
from ...common.decorators import language_id
109
from ...common.lsp_types import DocumentSymbol, SymbolInformation, SymbolKind
@@ -31,7 +30,6 @@ def __init__(self, parent: RobotLanguageServerProtocol) -> None:
3130
parent.document_symbols.collect.add(self.collect)
3231

3332
@language_id("robotframework")
34-
@threaded()
3533
@_logger.call
3634
async def collect(
3735
self, sender: Any, document: TextDocument

robotcode/language_server/robotframework/parts/folding_range.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import ast
44
from typing import TYPE_CHECKING, Any, List, Optional, cast
55

6-
from ....utils.async_tools import threaded
76
from ....utils.logging import LoggingDescriptor
87
from ...common.decorators import language_id
98
from ...common.lsp_types import FoldingRange
@@ -24,7 +23,6 @@ def __init__(self, parent: RobotLanguageServerProtocol) -> None:
2423
parent.folding_ranges.collect.add(self.collect)
2524

2625
@language_id("robotframework")
27-
@threaded()
2826
@_logger.call
2927
async def collect(self, sender: Any, document: TextDocument) -> Optional[List[FoldingRange]]:
3028

robotcode/language_server/robotframework/parts/formatting.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import re
77
from typing import TYPE_CHECKING, Any, List, Optional, cast
88

9-
from ....utils.async_tools import threaded
109
from ....utils.logging import LoggingDescriptor
1110
from ...common.decorators import language_id
1211
from ...common.lsp_types import (
@@ -61,7 +60,6 @@ async def get_config(self, document: TextDocument) -> Optional[RoboTidyConfig]:
6160
return await self.parent.workspace.get_configuration(RoboTidyConfig, folder.uri)
6261

6362
@language_id("robotframework")
64-
@threaded()
6563
@_logger.call
6664
async def format(
6765
self, sender: Any, document: TextDocument, options: FormattingOptions, **further_options: Any

robotcode/language_server/robotframework/parts/goto.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
)
1717

1818
from ....utils.async_itertools import async_next
19-
from ....utils.async_tools import threaded
2019
from ....utils.logging import LoggingDescriptor
2120
from ....utils.uri import Uri
2221
from ...common.decorators import language_id
@@ -72,15 +71,13 @@ def _find_method(self, cls: Type[Any]) -> Optional[_CollectMethod]:
7271
return None
7372

7473
@language_id("robotframework")
75-
@threaded()
7674
@_logger.call
7775
async def collect_definition(
7876
self, sender: Any, document: TextDocument, position: Position
7977
) -> Union[Location, List[Location], List[LocationLink], None]:
8078
return await self.collect(document, position, CollectType.DEFINITION)
8179

8280
@language_id("robotframework")
83-
@threaded()
8481
@_logger.call
8582
async def collect_implementation(
8683
self, sender: Any, document: TextDocument, position: Position

robotcode/language_server/robotframework/parts/hover.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
)
1616

1717
from ....utils.async_itertools import async_next
18-
from ....utils.async_tools import threaded
1918
from ....utils.logging import LoggingDescriptor
2019
from ...common.decorators import language_id
2120
from ...common.lsp_types import Hover, MarkupContent, MarkupKind, Position
@@ -62,7 +61,6 @@ def _find_method(self, cls: Type[Any]) -> Optional[_HoverMethod]:
6261

6362
return None
6463

65-
@threaded()
6664
@language_id("robotframework")
6765
@_logger.call
6866
async def collect(self, sender: Any, document: TextDocument, position: Position) -> Optional[Hover]:

robotcode/language_server/robotframework/parts/inline_value.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from typing import TYPE_CHECKING, Any, Generator, List, Optional, Tuple
55

66
from ....utils.async_itertools import async_dropwhile, async_takewhile
7-
from ....utils.async_tools import threaded
87
from ....utils.logging import LoggingDescriptor
98
from ...common.decorators import language_id
109
from ...common.lsp_types import (
@@ -39,7 +38,6 @@ def __init__(self, parent: RobotLanguageServerProtocol) -> None:
3938
parent.inline_value.collect.add(self.collect)
4039

4140
@language_id("robotframework")
42-
@threaded()
4341
@_logger.call
4442
async def collect(
4543
self, sender: Any, document: TextDocument, range: Range, context: InlineValueContext

0 commit comments

Comments
 (0)